Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 2 GTT fix miscellaneous bugs and add Displaced TrackJet HT #44678

Merged

Conversation

NJManganelli
Copy link
Contributor

PR description:

This PR combines several smaller PRs that fixed bugs and made additions for Phase 2 GTT workflows (outside of the nominal SimL1 workflow), as recommended by @aloeliger:

(1)
"This PR fixes cases when no options to load tracks or vertices from buffers is specified in the GTT F/W workflow and the input file does not contain lists of buffers to load from

This does not affect nominal workflows pertaining to AR; but this is also not time-sensitive and can be deferred in review as needed."

(2)
"Phase 2 GTT fix off-by-one error and collection mismatch in L1TrackObjectNtupleMaker"

(3)
"This PR adds the GTT Displaced Track HT(Miss) word into the emulation buffers for GTT to GlobalTrigger (the buffers encoding jets, sums, vertices, etc. and eventually mesons, taus, isolated tracks...)"

PR validation:

scram b code-format
scram b code-checks
scram b

  • the checks in the integration branch appropriate to each PR (running NTuplizer, GTT firmware buffer workflow, etc.)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is an aggregate combining the following small PRs from cms-l1t-offline Phase 2 integration branch:
cms-l1t-offline#1233
cms-l1t-offline#1234
cms-l1t-offline#1235

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44678/39877

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

A new Pull Request was created by @NJManganelli for master.

It involves the following packages:

  • L1Trigger/DemonstratorTools (l1)
  • L1Trigger/L1TTrackMatch (l1, upgrade)

@epalencia, @cmsbuild, @subirsarkar, @srimanob, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd90ad/38728/summary.html
COMMIT: b336e7a
CMSSW: CMSSW_14_1_X_2024-04-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44678/38728/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 64 lines to the logs
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3316263
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3316240
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e7c9b55 into cms-sw:master Apr 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants