-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 2 GTT fix miscellaneous bugs and add Displaced TrackJet HT #44678
Phase 2 GTT fix miscellaneous bugs and add Displaced TrackJet HT #44678
Conversation
…W buffers for OutputToGlobalTrigger
…ker.cc selected track indices
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44678/39877
|
A new Pull Request was created by @NJManganelli for master. It involves the following packages:
@epalencia, @cmsbuild, @subirsarkar, @srimanob, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd90ad/38728/summary.html Comparison SummarySummary:
|
+l1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR combines several smaller PRs that fixed bugs and made additions for Phase 2 GTT workflows (outside of the nominal SimL1 workflow), as recommended by @aloeliger:
(1)
"This PR fixes cases when no options to load tracks or vertices from buffers is specified in the GTT F/W workflow and the input file does not contain lists of buffers to load from
This does not affect nominal workflows pertaining to AR; but this is also not time-sensitive and can be deferred in review as needed."
(2)
"Phase 2 GTT fix off-by-one error and collection mismatch in L1TrackObjectNtupleMaker"
(3)
"This PR adds the GTT Displaced Track HT(Miss) word into the emulation buffers for GTT to GlobalTrigger (the buffers encoding jets, sums, vertices, etc. and eventually mesons, taus, isolated tracks...)"
PR validation:
scram b code-format
scram b code-checks
scram b
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is an aggregate combining the following small PRs from cms-l1t-offline Phase 2 integration branch:
cms-l1t-offline#1233
cms-l1t-offline#1234
cms-l1t-offline#1235