Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jet Matching and Gridpack Updates for madgraph_amc@nlo + Pythia 8 (71x) #4468

Merged
merged 23 commits into from Jul 8, 2014
Merged

Jet Matching and Gridpack Updates for madgraph_amc@nlo + Pythia 8 (71x) #4468

merged 23 commits into from Jul 8, 2014

Conversation

bendavid
Copy link
Contributor

@bendavid bendavid commented Jul 1, 2014

Backport of #4463 in preparation for Run 2 GEN-SIM production.

bendavid and others added 20 commits June 13, 2014 00:08
@bendavid
add pythia8 internal MLM-style matching implementation (code temporar…
34b7600 
…ily copied into cms repository)
@bendavid
first attempt to add #ptclus comment line parsing for excluding EWK-p…
d9b351c 
…roduced partons from matching
@bendavid
add reading and storage of npLO and npNLO LHE multiplicity tags used …
e6d3a72 
…to automate NLO merging
@bendavid
skip unknown xml tags within the <event> tags
233b5d1
@sdevissc @bendavid
Updated the JetMatchingPy8Internal.h code so that nPartons uses typeI…
435aa4e 
…dx instead of origTypeIdx in most of the places.
@sdevissc @bendavid
retrieve the DJR directly from JetMatchingPy8Internal.h
0da7eda
@sdevissc @bendavid
First move to record the DJR and nME values to edm
2c36be8
@sdevissc @bendavid
finalized the record in edm of the DJR values
bf54549
@sdevissc @bendavid
bug fix: nMEPartons reset for each new event
b815928
@sdevissc @bendavid
Adapt to most recent version of the JetMatchingP8internal.h code. DJR…
7e7b62f 
… estimation is now done using slowJet
@sdevissc @bendavid
bug fix: dealing with the veto on multiplicities higher than nJetMax
172faef
@bendavid
first implementation for single file CKKW matching
8818295
@bendavid
adapt to final xml tag format for cluster scales
54b1cb2
@bendavid
split jet matching interface into headers and src files
98bd615
@bendavid
add generic tarball run script for new style gridpacks with most of t…
c5df726 
…he runtime logic inside the tarball
@bendavid
bug fixes for djr maching validation implementation
b0fc94a
@bendavid
further improvements to djr storage (and remove intermediate class ve…
31ae172 
…rsions)
@bendavid
remove intermediate class versions for LHEEventProduct
0c29f37
@bendavid
add proper handling of ckkw weights
226f1eb
@bendavid
silence printouts in jet matching
218bc62
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_1_X.

Jet Matching and Gridpack Updates for madgraph_amc@nlo + Pythia 8 (71x)

It involves the following packages:

GeneratorInterface/LHEInterface
GeneratorInterface/PartonShowerVeto
GeneratorInterface/Pythia8Interface
SimDataFormats/GeneratorProducts

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

+1
Tested at: 757969e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4468/1777/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

Pull request #4468 was updated. @vciulli, @bendavid, @thuer can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4468/1777/summary.html

@bendavid
Copy link
Contributor Author

bendavid commented Jul 5, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jul 8, 2014
@davidlange6
Merge pull request #4468 from bendavid/py8matchingdev3
f03330e 
Jet Matching and Gridpack Updates for madgraph_amc@nlo + Pythia 8 (71x)
@davidlange6 davidlange6 merged commit f03330e into cms-sw:CMSSW_7_1_X Jul 8, 2014
@bendavid bendavid mentioned this pull request Jul 8, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed generators-approved orp-pending tests-pending
Projects
None yet
Milestone
CMSSW_7_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bendavid @cmsbuild @davidlange6 @sdevissc