Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HGCAL Hit calibration to Phase2 HLT. #44684

Merged

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Apr 10, 2024

PR description:

Backport of #44558 is needed for Spring24 HLT Upgrade sample validation.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

A new Pull Request was created by @rovere for CMSSW_14_0_X.

It involves the following packages:

  • HLTriggerOffline/Common (dqm)
  • Validation/HGCalValidation (dqm)

@nothingface0, @cmsbuild, @antoniovagnerini, @syuvivida, @rvenditti, @tjavaid can you please review it and eventually sign? Thanks.
@bsunanda, @hatakeyamak, @mtosi, @pfs, @apsallid, @cseez, @sethzenz, @vandreev11, @missirol, @lgray, @lecriste, @youyingli this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@rovere
Copy link
Contributor Author

rovere commented Apr 10, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88cbf9/38732/summary.html
COMMIT: 5f947cc
CMSSW: CMSSW_14_0_X_2024-04-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44684/38732/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3350124
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3350099
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 382.974 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 3.979 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_scint_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.977 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_100_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.977 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_200_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.977 KiB HGCalHitCalibrationHLT/hgcal_photon_EoP_CPene_300_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.976 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_scint_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.974 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_100_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.974 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_200_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.974 KiB HGCalHitCalibrationHLT/hgcal_ele_EoP_CPene_300_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.972 KiB HGCalHitCalibrationHLT/hgcal_EoP_CPene_scint_calib_fraction
  • DQMHistoSizes: changed ( 23234.0,... ): 3.970 KiB HGCalHitCalibrationHLT/hgcal_EoP_CPene_100_calib_fraction
  • DQMHistoSizes: changed ( 23234.0 ): ...
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Apr 11, 2024

@cms-sw/dqm-l2 please take a look.

@mmusich
Copy link
Contributor

mmusich commented Apr 11, 2024

backport of #44558

@mmusich
Copy link
Contributor

mmusich commented Apr 11, 2024

type hgcal

@srimanob
Copy link
Contributor

Kindly ping @cms-sw/dqm-l2
We need this PR before starting relvals in 14_0, to validate the Phase-2 MC before production. Thx.

@rovere
Copy link
Contributor Author

rovere commented Apr 16, 2024

@cms-sw/dqm-l2 could you please review and sign this PR?

@tjavaid
Copy link

tjavaid commented Apr 16, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor

Hi @rappoccio @antoniovilela
After merging this PR, could you please build a new 14_0 release? It is needed to start Phase-2 relvals and prepare for production. Thanks in advance.
FYI @rovere @SohamBhattacharya

@srimanob
Copy link
Contributor

Fix myself, we need also backport of #44431 before building new release.

@rappoccio
Copy link
Contributor

+1

  • We have some more urgent 14_0 issues so we'll wait for them to build the release.

@cmsbuild cmsbuild merged commit 1a17cbc into cms-sw:CMSSW_14_0_X Apr 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants