Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PSet of EvFDaqDirector in convertToRaw.py #44735

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Apr 15, 2024

PR description:

This PR updates convertToRaw.py in order to adapt to the fillDescriptions changes introduced in #43850. The utility convertToRaw does not currently work in 14_0_X and 14_1_X without this change. The change is merely technical: none of the values of the existing parameters are changed. A typo in convertToRaw is also fixed.

Merely technical. No changes expected.

(It would be good to add a unit test for this utility, but I currently do not have enough time to implement a proper one, and I would not delay this fix.)

FYI: @fwyzard

PR validation:

The test below works in CMSSW_14_1_0_pre2 only post-PR. For reference, the runtime error pre-PR is copied below.

convertToRaw -f 100 -l=-1 root://eoscms.cern.ch//eos/cms/tier0/store/data/Run2024C/EphemeralHLTPhysics0/RAW/v1/000/379/416/00000/9785dc6a-6211-4a80-a721-c1d4bb0e399b.root
----- Begin Fatal Exception 15-Apr-2024 10:22:08 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of service of type EvFDaqDirector
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'requireTransfersPSet'
 'selectedTransferMode'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

To be backported to CMSSW_14_0_X for trigger studies on 2024 data.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44735/39953

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol for master.

It involves the following packages:

  • HLTrigger/Tools (hlt)

@cmsbuild, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fwyzard, @silviodonato this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2024

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d3ac/38844/summary.html
COMMIT: d25081c
CMSSW: CMSSW_14_1_X_2024-04-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44735/38844/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 62 lines to the logs
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3317870
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3317844
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d196077 into cms-sw:master Apr 15, 2024
11 checks passed
@missirol missirol deleted the devel_fixPSetInConvertToRaw branch April 15, 2024 17:49
@missirol
Copy link
Contributor Author

Mh.. The bot changed a label from tests-approved to tests-started. Not sure why (FYI: @smuzaffar).

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d3ac/38859/summary.html
COMMIT: d25081c
CMSSW: CMSSW_14_1_X_2024-04-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44735/38859/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

Mh.. The bot changed a label from tests-approved to tests-started. Not sure why (FYI: @smuzaffar).

@missirol , we are looking in to it.

@smuzaffar
Copy link
Contributor

ping, lets see if bot triggers tests for this ( I think it will after cms-sw/cms-bot#2214 )

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24d3ac/38928/summary.html
COMMIT: d25081c
CMSSW: CMSSW_14_1_X_2024-04-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44735/38928/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319599
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319576
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants