Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ZS thresholds for SiPMs #4474

Merged
merged 1 commit into from Jul 1, 2014
Merged

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Jul 1, 2014

This commit specifies higher zero suppression thresholds to account for the effects of aging on SiPMs.
It needs to be included for any reprocessing of 2019 aging samples.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_6_2_X_SLHC.

New ZS thresholds for SiPMs

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

For posterity here are Kevin's validation plots (sent privately by email).

page1
page2
page3

@mark-grimes
Copy link

Checked that the new changes to the config are propagated if the correct

--customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_<lumi>

is passed to cmsDriver.py. Few more tests ongoing.

@mark-grimes
Copy link

merge

Tested all scenarios with 4 muons just to make sure it doesn't affect their configuration, tested 10261 (2019 with pions). Also tried with

runTheMatrix.py -w upgrade -l 10261 --command="--customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_300"

and got the failure

----- Begin Fatal Exception 01-Jul-2014 19:01:11 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
StatusMismatch: Parameter 'debugParameters' is designated as tracked in the code,
but is designated as untracked in the configuration file.
Please remove 'untracked' from the configuration file for parameter 'debugParameters'.
----- End Fatal Exception -------------------------------------------------

in step 2. Tried again with

runTheMatrix.py -w upgrade -l 10261 --command="--customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_2019,SLHCUpgradeSimulations/Configuration/aging.customise_aging_3000"

(i.e. included the original 2019 customise as well) and it runs fine and the new constants are propagated to the config. I guess the new "customise" parameter excludes the normal one from the matrix setup, so it's just important for whoever submits the jobs to include both.

cmsbuild added a commit that referenced this pull request Jul 1, 2014
@cmsbuild cmsbuild merged commit 17bd643 into cms-sw:CMSSW_6_2_X_SLHC Jul 1, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants