Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Ignore errors from alpaka::enqueue() in CachingAllocator::free() #44763

Conversation

makortel
Copy link
Contributor

PR description:

Backport of #44730. Original description

#44634 reported an HLT job failure caused by an illegal memory access on a GPU. The failure was reported as a crash instead of a caught exception because of a second exception being thrown from CachingAllocator<T>::free() by alpaka::enqueue() when objects using cached allocations were being deleted as part of the stack unwinding of the original exception.

The alpaka::enqueue() is used in CachingAllocator<T>::free() to "record" the alpaka Event in the Queue when the freed memory block is supposed to be recached. This PR changes the behavior such that if alpaka::enqueue() throws an exception, the memory block is treated as freed instead of recached.

I checked the alpaka Buffers, Queues, and Events that their destructors do not throw exceptions, but report any errors from the underlying APIs as printouts.

PR validation:

See #44730

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44730

@makortel makortel changed the title Ignore errors from alpaka::enqueue() in CachingAllocator::free() [14_0_X] Ignore errors from alpaka::enqueue() in CachingAllocator::free() Apr 17, 2024
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 17, 2024
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for CMSSW_14_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@fwyzard, @makortel, @cmsbuild can you please review it and eventually sign? Thanks.
@rovere, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2024

cms-bot internal usage

@makortel
Copy link
Contributor Author

enable gpu

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@fwyzard
Copy link
Contributor

fwyzard commented Apr 17, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-815051/38895/summary.html
COMMIT: ee87ccd
CMSSW: CMSSW_14_0_X_2024-04-17-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44763/38895/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 976
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38764
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor

fwyzard commented Apr 21, 2024

urgent

Please include in the next online (full or patch) release

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b1957d6 into cms-sw:CMSSW_14_0_X Apr 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants