Revert "CalorimeterDefinitions: don't return -1 as uint32_t"

[fwyzard]

PR description:

This reverts commit f0e4f78.

The change introduced by f0e4f78 / #44608 returns a dense id of 0 for an invalid det id. However, 0 is a valid dense id, and should not be used for an invalid det id.

PR validation:

None.

[fwyzard]

assign heterogeneous

[fwyzard]

+heterogeneous

[cmsbuild]

cms-bot internal usage

[fwyzard]

urgent

This is requested for CMSSW_14_1_0_pre3, to prevent invalid code in a prerelease.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44788/40024

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoParticleFlow/PFRecHitProducer/plugins/alpaka/CalorimeterDefinitions.h modified in PR(s): Do not include EventSetup record definitions in device code  #44682

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• RecoParticleFlow/PFRecHitProducer (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@hatakeyamak, @lgray, @mmarionncern, @missirol, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94c75/38978/summary.html
COMMIT: f7017cf
CMSSW: CMSSW_14_1_X_2024-04-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44788/38978/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 53 lines from the logs
• Reco comparison results: 42 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319852
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319829
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1