fix skipping qBin when reading template info

[mroguljic]

PR description:

Fixes a bug in the alpaka workflow when filling out template information used for error estimation in the generic algorithm for cluster parameter estimation. The current implementation would, for specific module and template combinations, fill information in wrong qBin categories. The effect of this is small as it only affects RecHit position errors for certain modules.

This fix was part of Irradiation Bias Correction at Alpaka PR. I am splitting it in two because IBC needs further studies.

PR validation:

runTheMatrix.py -l limited -i all --ibeos returns 47 46 45 36 19 1 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed

HLT timing comparison was made in 14_0_5 with the /dev/CMSSW_14_0_0/GRun configuration. Throughput between release and release + PR is 587.8 +/- 0.4 evt/s versus 587.0 +/- 2.9

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will backport to 14_0_X

[cmsbuild]

cms-bot internal usage

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44813/40061

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mroguljic for master.

It involves the following packages:

• RecoLocalTracker/SiPixelRecHits (reconstruction)

@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@VourMa, @dkotlins, @tvami, @JanFSchulte, @mmusich, @tsusa, @rovere, @threus, @GiacomoSguazzoni, @ferencek, @gpetruc, @felicepantaleo, @mroguljic, @missirol, @VinInn, @mtosi this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04dc65/39028/summary.html
COMMIT: 84f6a43
CMSSW: CMSSW_14_1_X_2024-04-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44813/39028/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 101 lines to the logs
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319852
• DQMHistoTests: Total failures: 8307
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3311525
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 2 / 46 workflows

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1