Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] TrackingMonitoringClient: fix axis labels for fake rate vs OnlineLumi, LS and PU #44833

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 24, 2024

backport of #44832

PR description:

Trivial bug-fix, noticed when looking at the recent (2024C) runs https://tinyurl.com/26yk5toj in the HLTMonitor DQM. These plots have been introduced from #42547.

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #44832 to 2024 data-taking release (CMSSW_14_0_X)

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 24, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Apr 24, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @jhgoh, @mtosi, @cericeci, @rociovilar, @Fedespring, @trocino, @HuguesBrun this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 24, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fc210/39079/summary.html
COMMIT: dc6cad6
CMSSW: CMSSW_14_0_X_2024-04-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44833/39079/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Apr 29, 2024

cms-sw/dqm-l2 please sign this straightforward fix

@tjavaid
Copy link

tjavaid commented Apr 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

@cms-sw/orp-l2 can we merge this? it's a trivial change and we will need to build a patch soon in any case, so we might profit from it.

Thanks!
Francesco as ORM

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 691d708 into cms-sw:CMSSW_14_0_X Apr 29, 2024
10 checks passed
@mmusich mmusich deleted the mm_fix_TrackingMonitoring_Client_cfff_14_0_X branch April 29, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants