Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] optimize and protect DisplacedRegionSeedingVertexProducer against busy events #44865

Merged

Conversation

mandrenguyen
Copy link
Contributor

backport of #44829

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2024

A new Pull Request was created by @mandrenguyen for CMSSW_14_0_X.

It involves the following packages:

  • RecoTracker/DisplacedRegionalTracking (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@dgulhan, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @VinInn, @gpetruc, @mmusich, @missirol, @rovere, @felicepantaleo, @VourMa this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-109ae3/39153/summary.html
COMMIT: 0938409
CMSSW: CMSSW_14_0_X_2024-04-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44865/39153/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432929
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3432900
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

@mandrenguyen is this a PR that we want to include in the next patch as well?

@mandrenguyen
Copy link
Contributor Author

@mandrenguyen is this a PR that we want to include in the next patch as well?

IFF it's not going to slow down this urgent patch, then indeed this should be included.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6f9d2fd into cms-sw:CMSSW_14_0_X Apr 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants