Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14_0_X] Add check on PATLeptonTimeLifeInfoProducer closestState valid state #44869

Merged
merged 2 commits into from
Apr 30, 2024
Merged

[14_0_X] Add check on PATLeptonTimeLifeInfoProducer closestState valid state #44869

merged 2 commits into from
Apr 30, 2024

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Apr 29, 2024 •
edited

PR description:

Combined backport of #44864 and #44875
While waiting on feedback from experts on the master PR (#44864), I'm opening this backport in the hope of speeding up the whole process.

PR validation:

See master PR for validation.

Backport:

Backport of #44864 and #44875

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 29, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2024 •
edited

A new Pull Request was created by @francescobrivio for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@mandrenguyen, @jfernan2, @hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@AlexDeMoor, @andrzejnovak, @rappoccio, @schoef, @nhanvtran, @jdamgov, @Senphy, @Ming-Yan, @seemasharmafnal, @castaned, @demuller, @mmarionncern, @gouskos, @ahinzmann, @mariadalfonso, @hatakeyamak, @mbluj, @azotz, @gkasieczka, @gpetruc, @jdolen this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2024 •
edited

cms-bot internal usage

@francescobrivio
Copy link
Contributor Author

backport of #44864

@francescobrivio
Copy link
Contributor Author

urgent

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aa093/39160/summary.html
COMMIT: 9a2e40f
CMSSW: CMSSW_14_0_X_2024-04-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44869/39160/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 82 lines to the logs
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3326485
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3326465
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@hqucms
Copy link
Contributor

hqucms commented Apr 29, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Apr 29, 2024

please test

@hqucms
Copy link
Contributor

hqucms commented Apr 29, 2024

type tau

@cmsbuild cmsbuild added the tau label Apr 29, 2024
@fwyzard
Copy link
Contributor

fwyzard commented Apr 29, 2024

How does the code that called produceAndFillIPInfo() know that the values stored in info are not valid ?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aa093/39165/summary.html
COMMIT: 9a2e40f
CMSSW: CMSSW_14_0_X_2024-04-29-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44869/39165/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 49 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.86 3.97 -2.7% 2.170 2.150
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.45 3.54 -2.6% 2.578 2.580
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.59 3.68 -2.2% 2.568 2.574
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.54 6.88 -4.9% 2.272 2.243
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.61 3.67 -1.6% 2.433 2.387
2500.012 1.761 1.761 0.000 ( +0.0% ) 5.06 5.43 -6.8% 2.376 2.380
2500.1 2.354 2.354 0.000 ( +0.0% ) 4.88 5.18 -5.7% 2.082 1.978
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.61 5.97 -6.0% 1.990 1.874
2500.21 1.286 1.286 0.000 ( +0.0% ) 4.11 4.26 -3.3% 2.297 2.176
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.62 3.81 -5.0% 2.359 2.186
2500.3 2.229 2.229 0.000 ( +0.0% ) 11.13 12.23 -9.0% 1.979 1.881
2500.301 2.833 2.833 0.000 ( +0.0% ) 10.08 10.71 -5.9% 1.963 1.839
2500.31 1.348 1.348 0.000 ( +0.0% ) 18.29 19.66 -7.0% 2.379 2.262
2500.311 1.757 1.757 0.000 ( +0.0% ) 14.58 15.50 -5.9% 2.447 2.267
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.50 1.50 +0.1% 1.694 1.693
2500.313 1.568 1.568 0.000 ( +0.0% ) 8.98 9.25 -2.9% 1.046 1.047
2500.314 1.236 1.236 0.000 ( +0.0% ) 13.44 14.78 -9.1% 2.205 2.105
2500.315 1.874 1.874 0.000 ( +0.0% ) 13.92 15.10 -7.8% 2.336 2.343
2500.316 3.342 3.342 0.000 ( +0.0% ) 1.96 2.09 -6.3% 2.309 2.121
2500.317 1.811 1.811 0.000 ( +0.0% ) 13.49 14.77 -8.6% 2.179 2.251
2500.318 4.136 4.136 0.000 ( +0.0% ) 5.35 5.84 -8.5% 2.192 2.129
2500.4 2.374 2.374 0.000 ( +0.0% ) 10.73 12.09 -11.2% 1.930 1.895
2500.401 1.885 1.885 0.000 ( +0.0% ) 9.02 10.36 -12.9% 1.697 1.705
2500.402 2.950 2.950 0.000 ( +0.0% ) 9.25 10.15 -8.9% 1.727 1.701
2500.403 5.474 5.474 0.000 ( +0.0% ) 1.35 1.48 -9.0% 1.806 1.798
2500.404 2.860 2.860 0.000 ( +0.0% ) 9.56 10.62 -10.0% 1.715 1.853
2500.405 8.700 8.700 0.000 ( +0.0% ) 3.39 3.70 -8.5% 1.893 1.912
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.12 16.36 -7.6% 1.662 1.547
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.32 10.01 -6.9% 1.608 1.616

@hqucms
Copy link
Contributor

hqucms commented Apr 29, 2024

+1

@cmsbuild
Copy link
Contributor

Pull request #44869 was updated. @vlimant, @hqucms, @mandrenguyen, @cmsbuild, @jfernan2 can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@fwyzard
Copy link
Contributor

fwyzard commented Apr 30, 2024

unhold

@cmsbuild cmsbuild removed the hold label Apr 30, 2024
@francescobrivio
Copy link
Contributor Author

backport of #44875

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aa093/39178/summary.html
COMMIT: e2dd018
CMSSW: CMSSW_14_0_X_2024-04-30-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44869/39178/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 49 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.87 3.96 -2.2% 2.149 2.175
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.49 3.55 -1.6% 2.588 2.606
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.60 3.62 -0.6% 2.578 2.606
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.65 6.82 -2.5% 2.283 2.286
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.59 3.68 -2.6% 2.463 2.433
2500.012 1.761 1.761 0.000 ( +0.0% ) 5.24 5.26 -0.5% 2.307 2.349
2500.1 2.354 2.354 0.000 ( +0.0% ) 5.09 5.15 -1.3% 1.976 2.084
2500.2 2.459 2.459 0.000 ( +0.0% ) 5.74 5.86 -2.0% 1.873 1.993
2500.21 1.286 1.286 0.000 ( +0.0% ) 4.12 4.26 -3.2% 2.169 2.300
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.70 3.79 -2.4% 2.185 2.350
2500.3 2.229 2.229 0.000 ( +0.0% ) 11.36 11.71 -3.0% 1.883 1.981
2500.301 2.833 2.833 0.000 ( +0.0% ) 10.21 10.32 -1.0% 1.806 1.968
2500.31 1.348 1.348 0.000 ( +0.0% ) 18.54 18.81 -1.4% 2.224 2.371
2500.311 1.757 1.757 0.000 ( +0.0% ) 14.56 15.59 -6.6% 2.264 2.460
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.54 1.48 +3.9% 1.700 1.693
2500.313 1.568 1.568 0.000 ( +0.0% ) 8.92 8.95 -0.4% 1.053 1.045
2500.314 1.236 1.236 0.000 ( +0.0% ) 13.71 14.39 -4.7% 2.100 2.248
2500.315 1.874 1.874 0.000 ( +0.0% ) 14.39 14.73 -2.3% 2.315 2.343
2500.316 3.342 3.342 0.000 ( +0.0% ) 1.97 2.05 -3.9% 2.122 2.305
2500.317 1.811 1.811 0.000 ( +0.0% ) 14.03 14.34 -2.2% 2.294 2.179
2500.318 4.136 4.136 0.000 ( +0.0% ) 5.60 5.60 -0.1% 2.300 2.228
2500.4 2.374 2.374 0.000 ( +0.0% ) 11.33 11.65 -2.7% 1.890 1.917
2500.401 1.885 1.885 0.000 ( +0.0% ) 9.87 9.98 -1.1% 1.690 1.693
2500.402 2.950 2.950 0.000 ( +0.0% ) 9.86 9.93 -0.7% 1.711 1.707
2500.403 5.474 5.474 0.000 ( +0.0% ) 1.41 1.44 -2.0% 1.813 1.818
2500.404 2.860 2.860 0.000 ( +0.0% ) 9.76 9.93 -1.7% 1.724 1.711
2500.405 8.700 8.700 0.000 ( +0.0% ) 3.47 3.55 -2.0% 1.882 1.900
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.63 16.01 -2.3% 1.573 1.671
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.71 9.71 -0.1% 1.596 1.598

@hqucms
Copy link
Contributor

hqucms commented Apr 30, 2024

+1

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor Author

@rappoccio @antoniovilela this is also fully signed, can we merge it and when you deem appropriate start the build of CMSSW_14_0_6_patch1?
Thanks!
Francesco

@antoniovilela
Copy link
Contributor

+1

  • Will build patch release and upload only after next IB passes.

@cmsbuild cmsbuild merged commit 167dd40 into cms-sw:CMSSW_14_0_X Apr 30, 2024
12 checks passed
@antoniovilela antoniovilela mentioned this pull request Apr 30, 2024
Closed
@francescobrivio francescobrivio deleted the alca-closestState_check_14_0_X branch May 5, 2024 09:55
@francescobrivio francescobrivio mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport fully-signed orp-approved reconstruction-approved tau tests-approved urgent xpog-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@francescobrivio @cmsbuild @hqucms @fwyzard @mandrenguyen @antoniovilela