Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forgotten NeutronKiller process, cleanup comments #4493

Merged
merged 1 commit into from Jul 3, 2014

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Jul 2, 2014

Added extra method to access Geant4 process ID. Added forgotten NeutronKiller process to the list of known processes. Clean-up comments.

Back-ported already integrated into 7_2_X PR 4477.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2014

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_1_X.

Added forgotten NeutronKiller process, cleanup comments

It involves the following packages:

SimG4Core/Physics

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor Author

civanch commented Jul 2, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Jul 3, 2014
SimG4Core/Physics -- Added forgotten NeutronKiller process, cleanup comments
@nclopezo nclopezo merged commit d8f3122 into cms-sw:CMSSW_7_1_X Jul 3, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants