Rpc noise configurable #4510

bapavlov · 2014-07-03T15:04:37Z

Some analysis demanded RPC to be switched off from a config fail. The code implements that feature, by doBkgNoise flag in the config file (SimMuon/RPCDigitizer/python/muonRPCDigis_cfi.py)

cmsbuild · 2014-07-03T15:07:49Z

A new Pull Request was created by @bapavlov for CMSSW_7_2_X.

Rpc noise configurable

It involves the following packages:

SimMuon/RPCDigitizer

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

civanch · 2014-07-03T17:23:56Z

+1
addition of this option is OK, however, it is not yet propagated to the new mixing module.

cmsbuild · 2014-07-03T17:27:44Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

cmsbuild · 2014-07-03T17:37:37Z

-1
Tested at: 0245600
I found an error when building:

gmake[1]: **\* [CompilePython] Error 1
gmake[1]: **\* Waiting for unfinished jobs....
gmake[1]: Leaving directory `/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-07-03-0200'
gmake: **\* [src] Error 2
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4510/255/summary.html

cmsbuild · 2014-07-03T17:37:50Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing).

civanch · 2014-07-03T17:48:24Z

-1
yes, please, add comma to previous line and update this PR.

A comma was missing. Now is fixed

bapavlov · 2014-07-04T10:03:15Z

I have fixed missing comma in muonRPCDigis_cfi.py file

cmsbuild · 2014-07-04T15:49:56Z

-1
Tested at: 3ec4205
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 04-Jul-2014 17:25:14 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=RPCDigiProducer label='simMuonRPCDigis'
Exception Message:
MissingParameter: Parameter 'doBkgNoise' not found.
----- End Fatal Exception -------------------------------------------------

401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log
----- Begin Fatal Exception 04-Jul-2014 17:26:12 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=RPCDigiProducer label='simMuonRPCDigis'
Exception Message:
MissingParameter: Parameter 'doBkgNoise' not found.
----- End Fatal Exception -------------------------------------------------

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 04-Jul-2014 17:26:59 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=RPCDigiProducer label='simMuonRPCDigis'
Exception Message:
MissingParameter: Parameter 'doBkgNoise' not found.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 04-Jul-2014 17:27:40 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=RPCDigiProducer label='simMuonRPCDigis'
Exception Message:
MissingParameter: Parameter 'doBkgNoise' not found.
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log
----- Begin Fatal Exception 04-Jul-2014 17:29:31 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=RPCDigiProducer label='simMuonRPCDigis'
Exception Message:
MissingParameter: Parameter 'doBkgNoise' not found.
----- End Fatal Exception -------------------------------------------------

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 04-Jul-2014 17:40:31 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=RPCDigiProducer label='simMuonRPCDigis'
Exception Message:
MissingParameter: Parameter 'doBkgNoise' not found.
----- End Fatal Exception -------------------------------------------------

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 04-Jul-2014 17:40:53 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=RPCDigiProducer label='simMuonRPCDigis'
Exception Message:
MissingParameter: Parameter 'doBkgNoise' not found.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4510/264/summary.html

cmsbuild · 2014-07-04T15:51:36Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing).

civanch · 2014-07-06T13:32:30Z

@bapavlov , it is possible to fix the problem, for example, if substitute
.....
timeJitter = cms.double(1.0),
doBkgNoise = cms.bool(True) #False - no noise and bkg simulation
),
by
..
timeJitter = cms.double(1.0)
),
doBkgNoise = cms.bool(True), #False - no noise and bkg simulation

Bugfix

bapavlov · 2014-07-07T08:14:43Z

Thank you, Vladimir ! Using your suggestion, I have fixed the problem.

cmsbuild · 2014-07-07T10:21:07Z

+1
Tested at: 3042f6b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4510/276/summary.html

cmsbuild · 2014-07-07T10:37:56Z

Pull request #4510 was updated. @civanch, @mdhildreth can you please check and sign again.

civanch · 2014-07-07T10:46:17Z

+1

cmsbuild · 2014-07-07T11:27:55Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

Rpc noise configurable

cmsbuild · 2014-07-08T10:23:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4510/276/summary.html

bapavlov added 3 commits July 3, 2014 16:45

RPC is could be swithed off in the config

2098f22

RPC is could be swithed off in the config

12e07a0

RPC is could be swithed off in the config

0245600

bapavlov added comparison-pending labels Jul 3, 2014

Update muonRPCDigis_cfi.py

3ec4205

A comma was missing. Now is fixed

bapavlov added comparison-pending labels Jul 4, 2014

bapavlov added simulation-approved labels Jul 4, 2014

bapavlov added comparison-pending labels Jul 4, 2014

Update muonRPCDigis_cfi.py

3042f6b

Bugfix

bapavlov added comparison-pending labels Jul 7, 2014

ktf added a commit that referenced this pull request Jul 7, 2014

Merge pull request #4510 from bapavlov/RPC_noise_configurable

9b57483

Rpc noise configurable

ktf merged commit 9b57483 into cms-sw:CMSSW_7_2_X Jul 7, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rpc noise configurable #4510

Rpc noise configurable #4510

bapavlov commented Jul 3, 2014

cmsbuild commented Jul 3, 2014

civanch commented Jul 3, 2014

cmsbuild commented Jul 3, 2014

cmsbuild commented Jul 3, 2014

cmsbuild commented Jul 3, 2014

civanch commented Jul 3, 2014

bapavlov commented Jul 4, 2014

cmsbuild commented Jul 4, 2014

cmsbuild commented Jul 4, 2014

civanch commented Jul 6, 2014

bapavlov commented Jul 7, 2014

cmsbuild commented Jul 7, 2014

cmsbuild commented Jul 7, 2014

civanch commented Jul 7, 2014

cmsbuild commented Jul 7, 2014

cmsbuild commented Jul 8, 2014

Rpc noise configurable #4510

Rpc noise configurable #4510

Conversation

bapavlov commented Jul 3, 2014

cmsbuild commented Jul 3, 2014

civanch commented Jul 3, 2014

cmsbuild commented Jul 3, 2014

cmsbuild commented Jul 3, 2014

cmsbuild commented Jul 3, 2014

civanch commented Jul 3, 2014

bapavlov commented Jul 4, 2014

cmsbuild commented Jul 4, 2014

cmsbuild commented Jul 4, 2014

civanch commented Jul 6, 2014

bapavlov commented Jul 7, 2014

cmsbuild commented Jul 7, 2014

cmsbuild commented Jul 7, 2014

civanch commented Jul 7, 2014

cmsbuild commented Jul 7, 2014

cmsbuild commented Jul 8, 2014