Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize members of struct to avoid problems with serialisation #4637

Merged
merged 1 commit into from Jul 14, 2014

Conversation

apfeiffer1
Copy link
Contributor

This PR fixes a problem in the serialisatoin unit test seen in the gcc490 builds, where a
non-initialised boolean variable causing problems as it's value was -1 (oxff) while the
C++ standard allows only 0 (false) and 1 (true), and the serialisation code (the EOS
portable binary archive) expects only the standard values.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

initialize members of struct to avoid problems with serialisation

It involves the following packages:

CondFormats/L1TObjects

@apfeiffer1, @nclopezo, @cmsbuild, @diguida, @rcastello, @ggovi, @Degano, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@apfeiffer1
Copy link
Contributor Author

+1

On Mon, Jul 14, 2014 at 12:32 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @apfeiffer1
https://github.com/apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

initialize members of struct to avoid problems with serialisation

It involves the following packages:

CondFormats/L1TObjects

@apfeiffer1 https://github.com/apfeiffer1, @nclopezo
https://github.com/nclopezo, @cmsbuild https://github.com/cmsbuild,
@diguida https://github.com/diguida, @rcastello
https://github.com/rcastello, @ggovi https://github.com/ggovi, @Degano
https://github.com/degano, @mulhearn https://github.com/mulhearn can
you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.


Reply to this email directly or view it on GitHub
#4637 (comment).

Thanks,
cheers, andreas

@ktf
Copy link
Contributor

ktf commented Jul 14, 2014

Trusting Andreas to compile code. Merging.

ktf added a commit that referenced this pull request Jul 14, 2014
Initialize members of struct to avoid problems with serialisation
@ktf ktf merged commit 89f92b2 into cms-sw:CMSSW_7_2_X Jul 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants