initialize members of struct to avoid problems with serialisation

[apfeiffer1]

This PR fixes a problem in the serialisatoin unit test seen in the CLANG builds, where a
non-initialised boolean variable causing problems as it's value was -1 (oxff) while the
C++ standard allows only 0 (false) and 1 (true), and the serialisation code (the EOS
portable binary archive) expects only the standard values.

[cmsbuild]

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

initialize members of struct to avoid problems with serialisation

It involves the following packages:

CondFormats/RPCObjects

@apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[apfeiffer1]

+1

On Mon, Jul 14, 2014 at 2:57 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @apfeiffer1
https://github.com/apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

initialize members of struct to avoid problems with serialisation

It involves the following packages:

CondFormats/RPCObjects

@apfeiffer1 https://github.com/apfeiffer1, @diguida
https://github.com/diguida, @cmsbuild https://github.com/cmsbuild,
@nclopezo https://github.com/nclopezo, @rcastello
https://github.com/rcastello, @ggovi https://github.com/ggovi, @Degano
https://github.com/degano can you please review it and eventually sign?
Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.

—
Reply to this email directly or view it on GitHub
#4638 (comment).

Thanks,
cheers, andreas

[davidlange6]

Andreas - do you expect that these changes address the gcc490 issues with the new CondDB ? I tested them locally with both PR 4637 and 4638 but see the same exceptions as before.

On Jul 14, 2014, at 3:02 PM, Andreas Pfeiffer notifications@github.com wrote:

+1

On Mon, Jul 14, 2014 at 2:57 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @apfeiffer1
https://github.com/apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

initialize members of struct to avoid problems with serialisation

It involves the following packages:

CondFormats/RPCObjects

@apfeiffer1 https://github.com/apfeiffer1, @diguida
https://github.com/diguida, @cmsbuild https://github.com/cmsbuild,
@nclopezo https://github.com/nclopezo, @rcastello
https://github.com/rcastello, @ggovi https://github.com/ggovi, @Degano
https://github.com/degano can you please review it and eventually sign?
Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.

—
Reply to this email directly or view it on GitHub
#4638 (comment).

Thanks,
cheers, andreas
—
Reply to this email directly or view it on GitHub.

[apfeiffer1]

Hi David,

Andreas - do you expect that these changes address the gcc490 issues with

the new CondDB ? I tested them locally with both PR 4637 and 4638 but see
the same exceptions as before.

well, yes, they fix the failing unit tests seen in the 490 and CLANG IBs.
What tests do you run which fail ?

Thanks,
cheers, andreas

[davidlange6]

Many relvals:

eg

https://cmssdt.cern.ch/SDT/cgi-bin//showMatrixTestLogs.py/slc6_amd64_gcc490/www/sat/7.2-sat-14/CMSSW_7_2_X_2014-07-12-1400/pyRelValMatrixLogs/run/

On Jul 14, 2014, at 7:29 PM, Andreas Pfeiffer notifications@github.com
wrote:

Hi David,

Andreas - do you expect that these changes address the gcc490 issues with

the new CondDB ? I tested them locally with both PR 4637 and 4638 but see
the same exceptions as before.

well, yes, they fix the failing unit tests seen in the 490 and CLANG IBs.
What tests do you run which fail ?

Thanks,
cheers, andreas
—
Reply to this email directly or view it on GitHub.

[apfeiffer1]

Many relvals:

eg

https://cmssdt.cern.ch/SDT/cgi-bin//showMatrixTestLogs.py/slc6_amd64_gcc490/www/sat/7.2-sat-14/CMSSW_7_2_X_2014-07-12-1400/pyRelValMatrixLogs/run/

OK, I'll have a look at these.

@ktf do you know if gcc490 has changed the handling of "legacy" bools
compared to oder versions ?
Concretely: if a bool is initialised with a number which is not 0 or 1 (as
the standard requires for false and true), is the behaviour defined or not
??

Thanks,
cheers, andreas

[cmsbuild]

+1
Tested at: 087867d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4638/332/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4638/332/summary.html

[diguida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).