Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restoring GE11 rotation bug for back compatibility #4644

Conversation

calabria
Copy link
Contributor

Bug: GEM chambers in SLHC11,12,13,14 were rotated by 10°. A partial fix was sent and included in SLHC15 that breaks the back compatibility. This PR restores the GE11 rotation bug to mantain the back compatibility with SLHC11,12,13 that are used for the GEN-SIM sample production (phase1 or phase2). Added also a small bug fix for the dqm tools.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @calabria (Cesare) for CMSSW_6_2_X_SLHC.

restoring GE11 rotation bug for back compatibility

It involves the following packages:

DQMServices/ClientConfig
Geometry/MuonCommonData

@civanch, @ojeda, @danduggan, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @rovere, @deguio, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

All testing fine, and diff confirms it is back to the SLHC14 geometry. I'll wait either for confirmation from geometry or discussion in the TP Studies meeting that this is what we want before merging (pretty sure it is, but no harm in checking).

@mark-grimes
Copy link

merge

Discussed in todays TP Studies meeting.

cmsbuild added a commit that referenced this pull request Jul 17, 2014
…tationBug

restoring GE11 rotation bug for back compatibility
@cmsbuild cmsbuild merged commit be51bd9 into cms-sw:CMSSW_6_2_X_SLHC Jul 17, 2014
@mark-grimes mark-grimes mentioned this pull request Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants