simplify charge computation

[civanch]

Method CoreSimTrack::charge() is visible in CPU profiler. Because of that it is re-written, data structure itself is not changed.

Constructors are cleaned up - all members of classes are initialized, unnecessary vectors are not created at construction.

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_2_X.

simplify charge computation

It involves the following packages:

SimDataFormats/Track

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[VinInn]

ping, test?

[cmsbuild]

+1
Tested at: c7a4a36
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4655/344/summary.html

[VinInn]

dramatically faster!
factor 5 even 6 taking into account the double precision division that I already got rid of in my version.
given that there are 202 libraries+plugins that depends on that (read 1 hour compilation on a fast machine) I suggest to move fast in approving this...

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4655/344/summary.html

[VinInn]

do not see any issue raising from comparisons...

[cmsbuild]

Pull request #4655 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

[civanch]

@Degano, would it be possible to restart tests? The recent commit is trivial, I have done it inside this PR in order do not have two separate small PR in the same library. This commit should change nothing but we have to redo tests.

[cmsbuild]

+1
Tested at: e43a379
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4655/349/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4655/349/summary.html