Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the HGCal calorimeter collections to the pileup mix #4691

Merged

Conversation

mark-grimes
Copy link

The mixing module only adds collections from the minimum bias files that it is told to into the pileup events. If it is not told to add a collection, then it will not be available to the accumulators in the PileUpEventPrincipal, even if the collection is in the input file. All collections for the signal event are always available.

Before this pull request only calorimeter hits from the signal event were digitised by the HGCal digitisers.

@lgray, @pfs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Add the HGCal calorimeter collections to the pileup mix

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@pfs
Copy link
Contributor

pfs commented Jul 17, 2014

Thanks Mark, do you have by chance a setup how i could test PU (in-time and out-of-time) and the digitizers for HGCal?
@vandreev11 follow this as well

@mark-grimes
Copy link
Author

This should do it with the SLHC15 relvals

cmsDriver.py step2 --conditions DES23_62_V1::All -n 10 --eventcontent FEVTDEBUGHLT -s DIGI:pdigi_valid,L1,DIGI2RAW --datatier GEN-SIM-DIGI-RAW --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_2023HGCalMuon --geometry Extended2023HGCalV4Muon,Extended2023HGCalV4MuonReco --magField 38T_PostLS1 --filein dbs:/RelValZTT_14TeV/CMSSW_6_2_0_SLHC15-DES23_62_V1_UPGHGCalV4-v1/GEN-SIM --fileout file:step2.root --pileup AVE_140_BX_25ns --pileup_input dbs:/RelValMinBias_TuneZ2star_14TeV/CMSSW_6_2_0_SLHC15-DES23_62_V1_UPGHGCalV4-v1/GEN-SIM
cmsDriver.py step3 --conditions DES23_62_V1::All -n 10 --eventcontent FEVTDEBUGHLT,DQM -s RAW2DIGI,L1Reco,RECO,VALIDATION,DQM --datatier GEN-SIM-RECO,DQM --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_2023HGCalMuon --geometry Extended2023HGCalV4Muon,Extended2023HGCalV4MuonReco --magField 38T_PostLS1 --filein file:step2.root --fileout file:step3.root --pileup AVE_140_BX_25ns --pileup_input dbs:/RelValMinBias_TuneZ2star_14TeV/CMSSW_6_2_0_SLHC15-DES23_62_V1_UPGHGCalV4-v1/GEN-SIM

You could drop the VALIDATION and DQM steps.

@lgray
Copy link
Contributor

lgray commented Jul 17, 2014

Good god, that command is so long you could kill someone with it.

@pfs
Copy link
Contributor

pfs commented Jul 17, 2014

great! thanks

@mark-grimes
Copy link
Author

merge

Tested on all scenarios. Had a weird harvesting error on some the Phase1 scenarios but passed on a retest.

cmsbuild added a commit that referenced this pull request Jul 20, 2014
Add the HGCal calorimeter collections to the pileup mix
@cmsbuild cmsbuild merged commit 2321c3b into cms-sw:CMSSW_6_2_X_SLHC Jul 20, 2014
@mark-grimes mark-grimes deleted the addHGCalCollectionsToMix branch March 23, 2015 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants