Bph mu tk

[lucamartini]

No description provided.

[lucamartini]

Added selections needed by BPH:

max muon eta
max dimuon rapidity
max invariant mass
dimuon charge
max distance of closest approach
max delta eta between the two muons

Their defaults are such that they do not change the behaviour of the old version of the module

[cmsbuild]

A new Pull Request was created by @lucamartini for CMSSW_7_2_X.

Bph mu tk

It involves the following packages:

HLTrigger/Muon

@perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[Martin-Grunewald]

-1

Please use proper code block indentation, replace fabs(.) by std::abs(.) and move the ESHandle'ing
of the magfield into the code block when the magfield is actually accessed.

[Martin-Grunewald]

Sorry, I meant do it only if if (m_maxDCAMuMu < 100.) {
as only then the magfield is actually needed....

[lucamartini]

Hi, about the ESHandle, there was a discussion on where to put it.
If we put it inside "if (m_maxDCAMuMu < 100.) {" that means it is inside the "for" loops, so the get method is accessed n * (n-1) times instead of once.

Can you specify where you see improper indentation? I don't see anything strange here, but maybe it is my editor tabulation

[Martin-Grunewald]

I mean to encapsulate this block inside an if-statement as well:
if (m_maxDCAMuMu < 100.) {

[lucamartini]

Hi,

you want to do this?

  // Needed for DCA calculation
  edm::ESHandle<MagneticField> bFieldHandle;
if (m_maxDCAMuMu < 100.)
  iSetup.get<IdealMagneticFieldRecord>().get(bFieldHandle);

Otherwise bFieldHandle is out of scope

[Martin-Grunewald]

yes... :)

[Martin-Grunewald]

Concerning indentation, I looked at what github displays:

https://github.com/lucamartini/cmssw/blob/BPH-MuTk/HLTrigger/Muon/src/HLTDiMuonGlbTrkFilter.cc

probably if you mix tabs and explicit whitespace it looks fine for you but not for others...

[cmsbuild]

Pull request #4699 was updated. @perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please check and sign again.

[cmsbuild]

+1
Tested at: 4f22740
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4699/375/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4699/375/summary.html

[Martin-Grunewald]

+1

Note: if you need this in 71X as well, make a (backport) PR for 71X.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).