Tracking vertex fix #4700

dnowatsc · 2014-07-18T12:43:05Z

Added the SimVertexs and refs to HepMC::GenVertexs to TrackingVertex in TrackingTruthAccumulator.cc and introduced two parameters in the trackingTruthProducer_cfi.py file, my changes are summarized in the last commit 35583bf. I also documented my changes in the source file, if they are insufficient please don't hesitate to send me an e-mail, also see my post in the Tracking hn.

The deletion of SimTracker/TrackHistory/plugins/TrackCategoriesAnalyzer.cc is more of an accident, I modified it to test my changes to the other files with it and removed it from the staging area in git so these changes will not be pushed; so if possible, please ignore this.

…eateTrackingVertex'; for GenVertexRef used same approach from 'TrackingTruthProducer' in 5X so add all GenVertexs within a distance of 0.003 cm to TrackingVertex

…al::getByLabel()' is already bypassed when calling 'TrackingTruthAccumulator::accumulate'; also 'vertexDistanceCut' and 'HepMCProductLabel' are added to SimGeneral/MixingModule/python/trackingTruthProducer_cfi.py as parameters

* in 'createTrackingVertex', add SimVertex to TrackingVertex which is created from the SimVertex ('returnValue.addG4Vertex(simVertex)') * also add ref to HepMC::GenVertexs in createTrackingVertex if it is a signal event; add all nearby GenVertexs (copied from old 'TrackingTruthProducer') * add handle to edm::HepMCProduct already in 'TrackingTruthAccumulator::accumulate' (and not in 'accumulateEvent') as 'event.getByLabel()' with it doesn't work with PileUpEventPrincipal * add parameter 'vertexDistanceCut' in SimGeneral/MixingModule/python/trackingTruthProducer_cfi.py to control this behaviour (set to 0.003 cm by default) * also add 'HepMCProductLabel' parameter in trackingTruthProducer_cfi.py

cmsbuild · 2014-07-18T12:48:11Z

A new Pull Request was created by @dnowatsc for CMSSW_7_2_X.

Tracking vertex fix

It involves the following packages:

.gitignore
SimGeneral/MixingModule
SimGeneral/TrackingAnalysis
SimTracker/TrackHistory

@civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@wmtan, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

VinInn · 2014-07-18T12:49:08Z

remove .gitignore

VinInn · 2014-07-18T12:52:28Z

please fix SimTracker/TrackHistory/plugins/TrackCategoriesAnalyzer.cc

cp $CMSSW_RELEASE_BASE/src/SimTracker/TrackHistory/plugins/TrackCategoriesAnalyzer.cc .
git add SimTracker/TrackHistory/plugins/TrackCategoriesAnalyzer.cc
git commit ...

etc

VinInn · 2014-07-18T12:57:05Z

SimGeneral/TrackingAnalysis/plugins/TrackingTruthAccumulator.cc

+					Vector genPosition(rawPosition.x()/10.0, rawPosition.y()/10.0, rawPosition.z()/10.0);
+
+					double distance = sqrt( (tvPosition - genPosition).mag2() );
+


*0.1 is faster then /10.0

auto distance2 = (tvPosition - genPosition).mag2() ;
if (distance2 < vertexDistanceCut_*vertexDistanceCut_)
is faster
(redefine vertexDistanceCut_ as vertexDistanceCut2_ even better

dnowatsc · 2014-07-18T13:11:45Z

I don't really get what you mean in the last comment, is this just a naming convention (so vertexDistanceCut2_ because only the square of its value is used)?

VinInn · 2014-07-18T13:15:57Z

vertexDistanceCut2_ because only the square of its value is used
yes, to make sure in future people do not get confused

…esAnalyzer.cc plus a few changes in TrackingTruthAccumulator

cmsbuild · 2014-07-18T13:22:59Z

Pull request #4700 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

VinInn · 2014-07-18T13:28:54Z

SimGeneral/TrackingAnalysis/plugins/TrackingTruthAccumulator.cc

+
+					auto distance2 = (tvPosition - genPosition).mag2();
+
+					if (distance2 < vertexDistanceCut2_*vertexDistanceCut2_)


sorry I was not precise. I meant
vertexDistanceCut2_(vertexDistanceCut*vertexDistanceCut)
and
if (distance2 < vertexDistanceCut2_)

So you mean putting it like this in the constructor i.e. somewhere around line 520?

cmsbuild · 2014-07-18T14:03:07Z

Pull request #4700 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

cmsbuild · 2014-07-18T17:17:40Z

-1
Tested at: a11c8bb
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 18-Jul-2014 18:47:17 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'vertexDistanceCut' not found.
----- End Fatal Exception -------------------------------------------------

401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log
----- Begin Fatal Exception 18-Jul-2014 18:48:21 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'vertexDistanceCut' not found.
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log
----- Begin Fatal Exception 18-Jul-2014 18:56:13 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'vertexDistanceCut' not found.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4700/372/summary.html

lveldere · 2014-07-23T10:16:02Z

I asked Dominik in private for a few changes to avoid configuration duplication between FastSim and FullSim, I will approve as soon as it is clear whether Dominik can do this or not.

…rSelection_cfi.py to reduce overlaps between FastSim and FullSim

lveldere · 2014-07-24T11:53:07Z

+1
thanks a lot Dominik!

cmsbuild · 2014-07-24T11:57:59Z

Pull request #4700 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

cmsbuild · 2014-07-24T13:53:16Z

+1
Tested at: 78ef762
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4700/465/summary.html

civanch · 2014-07-24T14:17:33Z

+1

cmsbuild · 2014-07-24T14:17:54Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

Tracking vertex fix

cmsbuild · 2014-07-24T15:02:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4700/465/summary.html

cerati · 2014-08-18T14:26:56Z

validation report by @avartak spotted differences possibly due to this PR (https://hypernews.cern.ch/HyperNews/CMS/get/relval/3099/49.html)
Where can I find the test results? Links appear to be broken

cerati · 2014-08-18T14:37:45Z

Sorry, please ignore the request above - differences in FASTSIM are indeed expected (no difference in FULLSIM)

Dominik Nowatschin added 6 commits July 16, 2014 15:17

Added SimVertex and refs to HepMC::GenVertex to TrackingVertex in 'cr…

ba45722

…eateTrackingVertex'; for GenVertexRef used same approach from 'TrackingTruthProducer' in 5X so add all GenVertexs within a distance of 0.003 cm to TrackingVertex

Removed SimTracker/TrackHistory/ from tracking area

f2cb4ed

Added some more documentation

392dd79

Update branch TrackingVertexFix

1d114b1

dnowatsc added comparison-pending labels Jul 18, 2014

VinInn reviewed Jul 18, 2014
View reviewed changes

Restored .gitignore and SimTracker/TrackHistory/plugins/TrackCategori…

4043864

…esAnalyzer.cc plus a few changes in TrackingTruthAccumulator

dnowatsc added comparison-pending labels Jul 18, 2014

VinInn reviewed Jul 18, 2014
View reviewed changes

Some minor changes

a11c8bb

dnowatsc added comparison-pending labels Jul 18, 2014

dnowatsc added pending-signatures labels Jul 23, 2014

Modified trackingTruthProducerFastSim_cfi.py and trackingTruthProduce…

78ef762

…rSelection_cfi.py to reduce overlaps between FastSim and FullSim

dnowatsc added comparison-pending labels Jul 24, 2014

ktf added a commit that referenced this pull request Jul 24, 2014

Merge pull request #4700 from dnowatsc/TrackingVertexFix

a54ec31

Tracking vertex fix

ktf merged commit a54ec31 into cms-sw:CMSSW_7_2_X Jul 24, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking vertex fix #4700

Tracking vertex fix #4700

dnowatsc commented Jul 18, 2014

cmsbuild commented Jul 18, 2014

VinInn commented Jul 18, 2014

VinInn commented Jul 18, 2014

VinInn Jul 18, 2014

dnowatsc commented Jul 18, 2014

VinInn commented Jul 18, 2014

cmsbuild commented Jul 18, 2014

VinInn Jul 18, 2014

dnowatsc Jul 18, 2014

cmsbuild commented Jul 18, 2014

cmsbuild commented Jul 18, 2014

lveldere commented Jul 23, 2014

lveldere commented Jul 24, 2014

cmsbuild commented Jul 24, 2014

cmsbuild commented Jul 24, 2014

civanch commented Jul 24, 2014

cmsbuild commented Jul 24, 2014

cmsbuild commented Jul 24, 2014

cerati commented Aug 18, 2014

cerati commented Aug 18, 2014

		Vector genPosition(rawPosition.x()/10.0, rawPosition.y()/10.0, rawPosition.z()/10.0);

		double distance = sqrt( (tvPosition - genPosition).mag2() );


		auto distance2 = (tvPosition - genPosition).mag2();

		if (distance2 < vertexDistanceCut2_*vertexDistanceCut2_)

Tracking vertex fix #4700

Tracking vertex fix #4700

Conversation

dnowatsc commented Jul 18, 2014

cmsbuild commented Jul 18, 2014

VinInn commented Jul 18, 2014

VinInn commented Jul 18, 2014

VinInn Jul 18, 2014

Choose a reason for hiding this comment

dnowatsc commented Jul 18, 2014

VinInn commented Jul 18, 2014

cmsbuild commented Jul 18, 2014

VinInn Jul 18, 2014

Choose a reason for hiding this comment

dnowatsc Jul 18, 2014

Choose a reason for hiding this comment

cmsbuild commented Jul 18, 2014

cmsbuild commented Jul 18, 2014

lveldere commented Jul 23, 2014

lveldere commented Jul 24, 2014

cmsbuild commented Jul 24, 2014

cmsbuild commented Jul 24, 2014

civanch commented Jul 24, 2014

cmsbuild commented Jul 24, 2014

cmsbuild commented Jul 24, 2014

cerati commented Aug 18, 2014

cerati commented Aug 18, 2014