Feature/add parameters for fast jet #4705
Conversation
|
A new Pull Request was created by @clint-richardson (Clint Richardson) for CMSSW_7_2_X. Feature/add parameters for fast jet It involves the following packages: RecoJets/JetProducers @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
…orFastJet Feature/add parameters for fast jet
| yCut = cms.double(-1.0), | ||
| useFiltering = cms.bool(False), | ||
| rFilt = cms.double(-1.0), | ||
| nFilt = cms.int(-1), |
There was a problem hiding this comment.
Hi,
You added two parameters as cms.int(). This type does not exist.
You need to add it as cms.int32(.).
Please submit a new PR to correct this.
You can check for such errors by running
python hltak5CaloJets_cfi.py
|
PR #4799 fixes these issues. |
I added needed jet grooming parameters for hltak5CaloJets_cfi.py so that they can be used online/parsed into confdb. I also completed an additional (needed) change to FastjetJetProducer.cc as it's previous setup was to use grooming techniques if any of the parameters are present without regard to their value. For instance, if one specified useTrimming = cms.bool(False), the fastjet producer was written in such a way that it would in fact still use Trimming. This change is necessary so that all of the grooming parameters can be present in the cfi.py file without causing all instances of fastjet producers to use them. As a last note, the values set for grooming parameters are equal to the defaults used by fastjet in the absence of grooming -> there should be no effect with older config files which do not use these parameters.