Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the fix for old and new forward pixel DetId numbering to the Phase2 digitiser #4740

Merged

Conversation

mark-grimes
Copy link

Forgot to include SiPhase2Digitizer in #4714. As far as I can tell it's never used anywhere, but it's best to include the DetId fix in that as well.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Add the fix for old and new forward pixel DetId numbering to the Phase2 digitiser

It involves the following packages:

SimTracker/SiPhase2Digitizer

The following packages do not have a category, yet:

SimTracker/SiPhase2Digitizer

@cmsbuild, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

Only tested with muons. As far as I can tell there are no scenarios where this is in the sequence anyway.

cmsbuild added a commit that referenced this pull request Jul 22, 2014
Add the fix for old and new forward pixel DetId numbering to the Phase2 digitiser
@cmsbuild cmsbuild merged commit 7d2ef8d into cms-sw:CMSSW_6_2_X_SLHC Jul 22, 2014
@mark-grimes mark-grimes deleted the addDetIdFixToPhase2Digitiser branch August 3, 2015 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants