Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGM Fixes -- Shashlik #4746

Merged
merged 9 commits into from
Jul 23, 2014
Merged

EGM Fixes -- Shashlik #4746

merged 9 commits into from
Jul 23, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 22, 2014

Revive ECAL driven electrons, gedElectrons, gedPhotons, photons, for shashlik scenario.

NB: photons/electrons/whatever from shashlik do not have energy corrections since they don't exist (i.e. it is just raw energy).

@nancymarinelli @dbenedet

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

EGM Fixes -- Shashlik

It involves the following packages:

Geometry/CaloEventSetup
Geometry/CaloTopology
Geometry/HGCalCommonData
RecoEcal/EgammaCoreTools
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaPhotonAlgos
RecoEgamma/EgammaPhotonProducers
RecoParticleFlow/PFClusterTools
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @bachtis, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

All tests fine. No idea why github is saying Geometry/HGCalCommonData/data/v5/hgcalCons.xml changed, that is already in.

cmsbuild added a commit that referenced this pull request Jul 23, 2014
@cmsbuild cmsbuild merged commit 1b8d38d into cms-sw:CMSSW_6_2_X_SLHC Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants