Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for Exotica Dimuon Triggers #4748

Merged
merged 2 commits into from
Jul 23, 2014
Merged

Validation for Exotica Dimuon Triggers #4748

merged 2 commits into from
Jul 23, 2014

Conversation

trtomei
Copy link
Contributor

@trtomei trtomei commented Jul 22, 2014

Adding validation for Exotica Dimuon Triggers in CMSSW_7_2_X, as requested.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @trtomei for CMSSW_7_2_X.

Validation for Exotica Dimuon Triggers

It involves the following packages:

HLTriggerOffline/Exotica

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@deguio
Copy link
Contributor

deguio commented Jul 23, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

-1
Tested at: ca8f2c3
I found an error when building:

gmake[1]: **\* [CompilePython] Error 1
gmake[1]: **\* Waiting for unfinished jobs....
gmake[1]: Leaving directory `/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-07-22-1400'
gmake: **\* [src] Error 2
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4748/422/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing).

@trtomei
Copy link
Contributor Author

trtomei commented Jul 23, 2014

Added a missing comma that was making the tests fails.

@cmsbuild
Copy link
Contributor

Pull request #4748 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Jul 23, 2014

+1
to be tested again

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@@ -2,14 +2,20 @@

HighPtDimuonPSet = cms.PSet(
hltPathsToCheck = cms.vstring(
"HLT_Mu17_Mu8_v",
"HLT_Mu17_TkMu8_v",
#"HLT_Mu17_Mu8_v",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, do not comment code.

ktf added a commit that referenced this pull request Jul 23, 2014
@ktf ktf merged commit 7e30fff into cms-sw:CMSSW_7_2_X Jul 23, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants