-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing bug which causes filter to auto accept #4758
Conversation
A new Pull Request was created by @Sam-Harper for CMSSW_7_2_X. fixing bug which causes filter to auto accept It involves the following packages: HLTrigger/Egamma @perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks. |
Hi Sam, Please make another PR for 71X to backport this fix there. |
+1 Don't forget the backport to 71X. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. |
Thanks Martin, the delay was me re-running all the tests in the 71X nightly. I know it cant possible fail but good practice. Here is the 71X pull request for the back port. #4759 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
Fixing bug which causes filter to auto accept
This one line fix stops the HLT pixel match filter auto accepting events, a bug introduced in the last commit.