Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug which causes filter to auto accept #4758

Merged
merged 1 commit into from
Jul 23, 2014

Conversation

Sam-Harper
Copy link
Contributor

This one line fix stops the HLT pixel match filter auto accepting events, a bug introduced in the last commit.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Sam-Harper for CMSSW_7_2_X.

fixing bug which causes filter to auto accept

It involves the following packages:

HLTrigger/Egamma

@perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Martin-Grunewald
Copy link
Contributor

Hi Sam,

Please make another PR for 71X to backport this fix there.

@Martin-Grunewald
Copy link
Contributor

+1

Don't forget the backport to 71X.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@Sam-Harper
Copy link
Contributor Author

Thanks Martin, the delay was me re-running all the tests in the 71X nightly. I know it cant possible fail but good practice. Here is the 71X pull request for the back port. #4759

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jul 23, 2014
Fixing bug which causes filter to auto accept
@ktf ktf merged commit 637c6bb into cms-sw:CMSSW_7_2_X Jul 23, 2014
@cmsbuild
Copy link
Contributor

@Sam-Harper Sam-Harper deleted the EgammaPMBugFix branch November 9, 2014 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants