Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vertex validation #4775

Merged
merged 5 commits into from
Jul 25, 2014
Merged

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jul 24, 2014

This PR will fix an offset-by-one bug that was present in the old version while computing mistag and add a rather comprehensive documentation on how to run and use this validation package.

Further code improvements, mainly related to logic and speed, have been included.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_2_X.

Improve vertex validation

It involves the following packages:

Validation/RecoVertex

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@cerati, @venturia, @GiacomoSguazzoni, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@deguio
Copy link
Contributor

deguio commented Jul 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jul 25, 2014
@ktf ktf merged commit 4482e08 into cms-sw:CMSSW_7_2_X Jul 25, 2014
@cmsbuild
Copy link
Contributor

@rovere rovere deleted the improve_vertex_validation branch October 3, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants