Int monitor element fix

[aehart]

Converted int monitor elements to TH1 to fix a problem with harvesting int monitor elements.

[cmsbuild]

A new Pull Request was created by @aehart (Andrew Hart) for CMSSW_7_2_X.

Int monitor element fix

It involves the following packages:

DQM/SiPixelMonitorClient
DQM/SiPixelMonitorRawData

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

+1
Tested at: e43d7bd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4868/544/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4868/544/summary.html

[deguio]

@aehart
which kind of problem with ints in harvesting are you referring to?
thanks,
F.

[aehart]

I understand that during harvesting, the int monitor elements were not
being added as they should have been, but instead only the value from
the final file was being used. Switching to TH1 monitor elements fixes
the problem. I've been working with Duncan on this issue, so perhaps he
can elaborate further.

Cheers,
Andrew

On 08/13/2014 11:20 AM, deguio wrote:

@aehart https://github.com/aehart
which kind of problem with ints in harvesting are you referring to?
thanks,
F.

—
Reply to this email directly or view it on GitHub
#4868 (comment).

[leggat]

Hi @deguio

It was Dan that told me about the harvesting problem here - the Int type monitor elements were, as Andrew says, not actually being summed at all in the step3 file combination. As we were storing various related error parameters in arrays of int MEs it made sense to convert them to TH1s. I also think it's a better way to store the information aesthetically, but that's not the reason for the update...

Cheers,
Duncan

[danduggan]

@leggat This is great and a big help to pixel FED error monitoring. Thanks to you and @aehart for making this change.

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).