Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cms hi/hydjet v1.9 implementation #4962

Closed

Conversation

cbaus
Copy link

@cbaus cbaus commented Aug 15, 2014

As discussed in mail exchange. This pull request updates the hydjet version to v1.9
It also adds the necessary configs (drum tune from 2013) and the new ones for 2015 conditions for PbPb.

borrello and others added 24 commits July 7, 2014 15:50
Configuration updates for Online DQM / MWGR.
Skims under 711-Modified WMu name path
Fix compilation issue on gcc490.
New GTs for Run1 simulations, Run2 simulations, and data.
Revert "Skims under 711-Modified WMu name path"
…/cmssw into hydjet-v1.9-implementation

rebased to 7_2_X
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cbaus for CMSSW_7_2_X.

Cms hi/hydjet v1.9 implementation

It involves the following packages:

Configuration/Generator
GeneratorInterface/HydjetInterface

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@bendavid
Copy link
Contributor

Hi @cbaus, even if the diff is ok now, the commit history is very confusing (contains unrelated commits which are reverted by later commits)

Suggest starting from a clean branch on top of 72x and pulling in the needed files.

@cbaus cbaus closed this Aug 25, 2014
@harmonicoscillator harmonicoscillator deleted the CmsHI/hydjet-v1.9-implementation branch December 11, 2015 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants