Fix crash in DTDCSByLumiSummary when MonitorElements are missing #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change properly protects the module from the case where the MonitorElements it wants from DQMStore are not available. This fixes a crash seen in the threaded IB RelVals.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X. Fix crash in DTDCSByLumiSummary when MonitorElements are missing It involves the following packages: DQM/DTMonitorClient @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks. |
|
@ktf I thought you had merged this yesterday. |
|
I though as well, sorry about that. Merging. |
ktf
added a commit
that referenced
this pull request
Aug 19, 2014
Fix crash in DTDCSByLumiSummary when MonitorElements are missing
|
@Dr15Jones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change properly protects the module from the case where the
MonitorElements it wants from DQMStore are not available.
This fixes a crash seen in the threaded IB RelVals.