Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cfa renewal 72 x #5007

Merged
merged 19 commits into from Aug 22, 2014
Merged

Cfa renewal 72 x #5007

merged 19 commits into from Aug 22, 2014

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Aug 20, 2014

This was agreed with Taejeong.
There is some commits that are not mine even though I merge the topic from a 7.0 branch and observed only my changes on top of the 7_2_X IB.
Please point me to the proper toturial to get only my stuff in.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vlimant (vlimant) for CMSSW_7_2_X.

Cfa renewal 72 x

It involves the following packages:

CommonTools/UtilAlgos
PhysicsTools/PatUtils
PhysicsTools/RecoUtils
PhysicsTools/UtilAlgos

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@nhanvtran, @TaiSakuma, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1
Tested at: 8ed9d43
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-08-20-0200/src/PhysicsTools/PatUtils/src/PATDiObjectProxy.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-08-20-0200/src/PhysicsTools/PatUtils/src/RazorComputer.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-08-20-0200/src/PhysicsTools/PatUtils/src/SimpleJetTrackAssociator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-08-20-0200/src/PhysicsTools/PatUtils/src/StringParserTools.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-08-20-0200/src/PhysicsTools/PatUtils/src/RazorComputer.cc: In constructor 'RazorBox::RazorBox(const CachingVariable::CachingVariableFactoryArg&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-08-20-0200/src/PhysicsTools/PatUtils/src/RazorComputer.cc:7:47: error: no matching function for call to 'CachingVariable::CachingVariable(const char [9], std::string&, edm::ParameterSet&)'
   CachingVariable("RazorBox",arg.n,arg.iConfig){
                                               ^
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-08-20-0200/src/PhysicsTools/PatUtils/src/RazorComputer.cc:7:47: note: candidates are:
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-08-20-0200/src/PhysicsTools/PatUtils/interface/RazorComputer.h:3:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-08-20-0200/src/PhysicsTools/PatUtils/src/RazorComputer.cc:1:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5007/653/summary.html

@slava77
Copy link
Contributor

slava77 commented Aug 21, 2014

+1

for #5007 120bdaa

@monttj
Copy link
Contributor

monttj commented Aug 22, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Aug 22, 2014
PhysicsTools -- Cfa renewal 72 x
@nclopezo nclopezo merged commit 69ba9d6 into cms-sw:CMSSW_7_2_X Aug 22, 2014
@vlimant vlimant deleted the cfa_renewal_72X branch April 7, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants