Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Isolation & Selection Frameworks 71X Edition #5015

Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 21, 2014

71X Backport of #5011

@arizzi @ikrav @Sam-Harper

lgray and others added 30 commits August 20, 2014 20:18
…ition for full 5x5, added a new set of working points
@slava77
Copy link
Contributor

slava77 commented Sep 9, 2014

ping
fastsim signature is missing here.
Are there any issues to sign?

@lveldere
Copy link
Contributor

lveldere commented Sep 9, 2014

+1

no issue, just a bit tired after signing for the 3rd time for 1 line of FastSim code :-)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 9, 2014
Common Isolation & Selection Frameworks 71X Edition
@davidlange6 davidlange6 merged commit d9a03b7 into cms-sw:CMSSW_7_1_X Sep 9, 2014
@lgray
Copy link
Contributor Author

lgray commented Sep 9, 2014

@lveldere Next time I'll buy you a beer :-)

@davidlange6
Copy link
Contributor

@lgray - a belated question on this pull request - while available in python versions used by CMSSW (2.7+), importlib is not available in python 2.6 which we appear to need to support at least for the moment ( :( ) . Is there something in import lib that does something more than import that you rely on in this PR?

@vadler

@lgray
Copy link
Contributor Author

lgray commented Sep 23, 2014

@davidlange6 importlib is used so that I can (without too much hassle) dynamically grab cut flow configurations. I'd need to go figure out the old way to do this.

@davidlange6
Copy link
Contributor

I think
d=import(blah) does the same thing. Is there an easy way for me to test? (e.g., if I can run the miniAOD in 7_0_9 plus this change, is that sufficient?)

On Sep 23, 2014, at 1:01 PM, Lindsey Gray notifications@github.com
wrote:

@davidlange6 importlib is used so that I can (without too much hassle) dynamically grab cut flow configurations. I'd need to go figure out the old way to do this.


Reply to this email directly or view it on GitHub.

@lgray
Copy link
Contributor Author

lgray commented Sep 23, 2014

Just make the appropriate change in https://github.com/cms-sw/cmssw/pull/5015/files#diff-e7553c3b18dedb4aa37ad8a4fa36b390R30 and then you can try running a miniAOD matrix test.

@davidlange6
Copy link
Contributor

Done - I just make a PR (#5501)

On Sep 23, 2014, at 2:10 PM, Lindsey Gray notifications@github.com
wrote:

Just make the appropriate change in https://github.com/cms-sw/cmssw/pull/5015/files#diff-e7553c3b18dedb4aa37ad8a4fa36b390R30 and then you can try running a miniAOD matrix test.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants