Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up DDRoot #5029

Merged
merged 1 commit into from Aug 25, 2014
Merged

Clean up DDRoot #5029

merged 1 commit into from Aug 25, 2014

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 22, 2014

  • no need for friendship
  • remove commented out code

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_2_X.

Clean up DDRoot

It involves the following packages:

DetectorDescription/Core

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor Author

ianna commented Aug 25, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Aug 25, 2014
@ktf ktf merged commit 3029d27 into cms-sw:CMSSW_7_2_X Aug 25, 2014
@ianna ianna deleted the remove-singleton-friend branch October 26, 2015 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants