New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAT fix to deal with GTs with added payloads #5053
Conversation
A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_2_X. PAT fix to deal with GTs with added payloads It involves the following packages: PhysicsTools/PatAlgos @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks. |
Bypassing to get this in the IB. |
PAT fix to deal with GTs with added payloads
Its fine for the IB, but its clearly the wrong solution - we now have two meanings of auto:startup (unless I misunderstand) On Aug 26, 2014, at 1:27 PM, Giulio Eulisse notifications@github.com
|
Hmm, no, not really. What we have is that the syntax format of the GT could be either just This was already the case previously (see autoCond.py), and GlobalTag.py in It is just that some code still assumes a globaltag |
On Aug 26, 2014, at 2:43 PM, Martin Grunewald notifications@github.com
Yes, I see that. The "fix" appears to be to ignore the appended payloads. Or do I misunderstand?
|
Yes, but this is on purpose as it is just the default initialisation In the 2 originally failing unit test cases, this gets overwritten by the user |
PAT fix to deal with GTs with added payloads.
This is just in the initialisation step when digesting the default GT 'startup',
which now contains added payloads!