Avoid holding excessive numbers of file handles open #5080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running threaded jobs with 10 threads, the job would fail because
it ran out of file handles. This change allows the code to only open
one instance of the TFile and then closes the file once all necessary
information has been read. This works since the objects pulled from
the TFile are cloned so memory ownership is transfered.
As part of the change, memory management was simplified via the use
of std::unique_ptr.