Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exotica HLT validation : latest developments #5105

Merged
merged 62 commits into from Sep 7, 2014

Conversation

ndaci
Copy link
Contributor

@ndaci ndaci commented Aug 29, 2014

We monitor di-electron, single electron, di-photons, single photon, di-muon paths.
The validation plots are in general reasonable, although we still need to fix some features.
We plan to fix all features and fully fix our currently buggy trigger paths (others than the paths mentioned above) by our next pull request (should come at the end of next week).
This will be extremely useful to us to help further developments to have our current version integrated in the validation workflow.

ndaci and others added 30 commits July 22, 2014 19:03
… frozenHLT RelVal, whereas Run2 paths will be checked with standard RelVal.
…HLT RelVal, whereas Run2 path will be checked with standard RelVal.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2014

Pull request #5105 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Sep 7, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

davidlange6 added a commit that referenced this pull request Sep 7, 2014
Exotica HLT validation : latest developments
@davidlange6 davidlange6 merged commit 194dd5d into cms-sw:CMSSW_7_2_X Sep 7, 2014
@deguio
Copy link
Contributor

deguio commented Sep 11, 2014

@ndaci could you please provide a fix and submit a new PR?
you can reproduce the error by running:

runTheMatrix -l 22.0

please sent me an email if you have questions.
thanks,
F.

@ndaci
Copy link
Contributor Author

ndaci commented Sep 11, 2014

Hi, sorry we are in a workshop with limited access to internet.
My colleague Ryo tried and could not reproduce the crash.
We will investigate further asap.

Thanks
Nadir & Ryo

Le jeudi 11 septembre 2014, deguio notifications@github.com a écrit :

@ndaci could you please provide a fix and submit a new PR?
you can reproduce the error by running:

runTheMatrix -l 22.0

please sent me an email if you have questions.
thanks,
F.


Reply to this email directly or view it on GitHub.<
https://ci4.googleusercontent.com/proxy/Vcp4qJ22y_akGO__YXtH5-pJfcmPqreFXCxtidbPEK0Xz1CQAitH3qfZivxTp3D1iVgqVEUTjlq02mkVO7OQqgfwkLhCeE6UA-WZAnZIMbtwOaW5bshJBpCxGtSNmqIUf2QT_i_G1ADOCf7GSyW1fQdl3jIXHZny9M_8QQeeJGh7hU8TqDGflq_WHau7CAv3Gc65xUkjo9kDskblGqYkpqiRX8Mnoj8uWvge6RakSFhryj_Ujx2Y4FLJrHKE4w7iCx6Mj03MhocY_ALiMaqT5M_qfrGApQ=s0-d-e1-ft#https://github.com/notifications/beacon/4929876__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyNjA2MTAzMywiZGF0YSI6eyJpZCI6NDEwNDc3MDZ9fQ==--b4fcff220305e1cee563686513f35d353ec5588c.gif>

#"HLT_Mu17_TkMu8_v",
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_Mu30_TkMu11_v",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR had been reverted, and therefore it is not in the IB.
Anyhow, is it normal that you remove the monitoring of this HLT_Mu30_TkMu11 path, which is one of those requested for the Run2 HLT menu and already included in GRun since a while? Perhaps slipped out? Please check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some confusion about the exact thresholds, this is fixed now, I'm
putting this path back.

2014-09-15 11:49 GMT+02:00 perrotta notifications@github.com:

In HLTriggerOffline/Exotica/python/analyses/hltExoticaHighPtDimuon_cff.py:

@@ -2,20 +2,15 @@

HighPtDimuonPSet = cms.PSet(
hltPathsToCheck = cms.vstring(

  •    #"HLT_Mu17_Mu8_v",
    
  •    #"HLT_Mu17_TkMu8_v",
    
  •    "HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_v",
    
  •    "HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
    
  •    "HLT_Mu30_TkMu11_v",
    

This PR had been reverted, and therefore it is not in the IB.
Anyhow, is it normal that you remove the monitoring of this
HLT_Mu30_TkMu11 path, which is one of those requested for the Run2 HLT menu
and already included in GRun since a while? Perhaps slipped out? Please
check.


Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/5105/files#r17533326.

@ndaci
Copy link
Contributor Author

ndaci commented Sep 15, 2014

I fixed a problem in the code: the wrong collection of muons was used for the MuonNoBptx path, causing the out-of-range exception.
This is now pushed into the ExoValDev branch.
When testing within the last IB CMSSW_7_2_X_2014-09-15-0200 there is no exception anymore.

The dimuon trigger path list was fixed as well.

@perrotta
Copy link
Contributor

@ndaci : I see no changes in this PR. Since it results as being already merged, perhaps you have to create a new one starting from your branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants