New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port GEM software from 62XSLHC to 72X #5115
Conversation
@dildick, I would suggest if possible any specific upgrade, which change somehow code for 2015 to be included into separate PR(s) which should be discussed at simulation meeting. From this PR we may require that the code is integrated and does not disturb mainstream. In the next PR(s) you may achieve desired physics performance. |
+1 |
@civanch Okay, sounds good. That's all then for this PR. |
Reco already signed off - so merging - complain if not ok |
Port GEM software from 62XSLHC to 72X
Hi,
As a first step to port the GEM software from 62XSLHC to 72X I started from (*) and listed all geometry-related commits. I ignored all non-GEM commits and commits that were simply merges. I solved most conflicts manually. The resulting code compiles, but I have not been able to test it yet. Which workflow can I use to test it?
EDIT: fixed various suggestions by Slava
EDIT2: include the frame rotation fixes in SimG4CMS/Muon
EDIT3: include ME0DigiPreReco dataformat from DataFormats/GEMDigi
EDIT4: update the digitizers in SimMuon/GEMDigitizer
EDIT5: update of the inclusion guards in various GEM and related header files
EDIT6: Minor fixes following suggestions by @slava77 , @civanch and @ianna
Cheers,
Sven
(*)