Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel Phase1 xmls for 72X #5133

Merged
merged 2 commits into from Sep 2, 2014
Merged

Pixel Phase1 xmls for 72X #5133

merged 2 commits into from Sep 2, 2014

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Sep 1, 2014

First round of XMLs files for 72X : starting with pixel phase1 synchronized with the latest developments in 62X_SLHC (@mark-grimes & @venturia : FYI, starting to update 72X with the upgrade geometries)
@atricomi : any xml updates should be kept synchronized with 7x from now

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2014

A new Pull Request was created by @boudoul (boudoul) for CMSSW_7_2_X.

Pixel Phase1 xmls for 72X

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2014

<rRotation name="pixbar:180D"/>
<!--
<rRotation name="pixbar:180D"/>
-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in my new commit, thanks
Le 2 sept. 2014 à 09:08, ianna a écrit :

In Geometry/TrackerCommonData/data/PhaseI/pixbar.xml:

@@ -1059,7 +1023,9 @@


+
It's better to remove it.


Reply to this email directly or view it on GitHub.

@ianna
Copy link
Contributor

ianna commented Sep 2, 2014

@boudoul - which scenario does it affect? Should a DB payload be updated as well?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2014

@boudoul
Copy link
Contributor Author

boudoul commented Sep 2, 2014

it's for any scenario >=2017.

There no upgrade GT for the upgrade in 72X so no DB payload to update at this point.

Thanks
Gaelle

Le 2 sept. 2014 à 09:10, ianna a écrit :

@boudoul - which scenario does it affect? Should a DB payload be updated as well?


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2014

Pull request #5133 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@ianna
Copy link
Contributor

ianna commented Sep 2, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Sep 2, 2014
Geometry/TrackerCommonData -- Pixel Phase1 xmls for 72X
@nclopezo nclopezo merged commit dda95d0 into cms-sw:CMSSW_7_2_X Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants