New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixel Phase1 xmls for 72X #5133
Conversation
A new Pull Request was created by @boudoul (boudoul) for CMSSW_7_2_X. Pixel Phase1 xmls for 72X It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks. |
<rRotation name="pixbar:180D"/> | ||
<!-- | ||
<rRotation name="pixbar:180D"/> | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in my new commit, thanks
Le 2 sept. 2014 à 09:08, ianna a écrit :
In Geometry/TrackerCommonData/data/PhaseI/pixbar.xml:
@@ -1059,7 +1023,9 @@
+
It's better to remove it.—
Reply to this email directly or view it on GitHub.
@boudoul - which scenario does it affect? Should a DB payload be updated as well? |
it's for any scenario >=2017. There no upgrade GT for the upgrade in 72X so no DB payload to update at this point. Thanks Le 2 sept. 2014 à 09:10, ianna a écrit :
|
Pull request #5133 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
Geometry/TrackerCommonData -- Pixel Phase1 xmls for 72X
First round of XMLs files for 72X : starting with pixel phase1 synchronized with the latest developments in 62X_SLHC (@mark-grimes & @venturia : FYI, starting to update 72X with the upgrade geometries)
@atricomi : any xml updates should be kept synchronized with 7x from now