update hltGetConfiguration for DAQ2

[fwyzard]

No description provided.

[fwyzard]

@Martin-Grunewald , @perrotta can you let me know if this works for you, or else how many things it breaks ?

.A

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_2_X.

update hltGetConfiguration for DAQ2

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

+1
Tested at: c55f6c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5164/796/summary.html

[Martin-Grunewald]

It seems you remove
-process.hltDQMFileSaver = cms.EDAnalyzer( "DQMFileSaver",
without adding anything to take its role.
??

[fwyzard]

Hi Martin,
in instrumentDQM(self), it is replaced by

dqmOutput = cms.OutputModule("DQMRootOutputModule",
    fileName = cms.untracked.string("DQMIO.root")
)

DQMIO.root needs to be converted into a standard root file, either by the harvesting step, or by DQMIO2histo.py if one does not care about the additional plots from the harvesting.

.A

[Martin-Grunewald]

There is a problem. The extracted cfg files for our tests contain:

process.DQMOutput = cms.EndPath( process.hltDQMFileSaver )

but since the hltDQMFileSaver is vetoed, this leads
to a python crash. So perhaps the full endpath needs to be
killed, or hltDQMFileSaver should only be killed if one does --timing
??

[fwyzard]

Right, I forgot that the 7_1_1 menu does not have the DQM PoolOutputModule,
so removing the DQMileSaver leaves an empty path.

For the Run II menu:

• if you prefer to keep the DQMFileSaver in its own EndPath, then we need
  to drop the EndPath together with the module
• if you prefer to keep the DQMFileSaver in the same path as the
  hltOuputDQM (the output module for the online DQM stream), then we could
  add it to the menu, so that the EndPath is not empty ?

.A

On 4 September 2014 11:11, Martin Grunewald notifications@github.com
wrote:

There is a problem. The extracted cfg files for our tests contain:

process.DQMOutput = cms.EndPath( process.hltDQMFileSaver )

but since the hltDQMFileSaver is vetoed, this leads
to a python crash. So perhaps the full endpath needs to be
killed, or hltDQMFileSaver should only be killed if one does --timing
??

—
Reply to this email directly or view it on GitHub
#5164 (comment).

[Martin-Grunewald]

Sorry, I think the issue is that the hltDQMFileSaver module definition is
removed, but its 'reference' is still kept in the endpath
DQMOutput = cms.EndPath( hltDQMFileSaver )
which is in the 711 menus.
I guess edmConfigFromDB does not cean this up,
but python does not like an endpath with a module
which is not defined (-> the error).
Can you just append a DQMRootOutputModule to DQMOutput endpath?

[fwyzard]

Can you just append a DQMRootOutputModule to DQMOutput endpath?

Actually, I would need to pre-pend it, otherwise it may be affected by the prescalers.

[fwyzard]

OK, I've updated the confdb.py code to handle most (all ?) reasonable situations.

It seems to work for me for the latest GRun menu, now.

[fwyzard]

-1

does not work for the MWGR menu, now...

[cmsbuild]

Pull request #5164 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please check and sign again.

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5164/796/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

[Martin-Grunewald]

@nclopezo @ktf - merging please?

It seems when there is an intermediate -1 the labels do not reset properly
so that the tests are then not run...

[cmsbuild]

+1
Tested at: ef04e8d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5164/817/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5164/817/summary.html