Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have TkCloner return std::unique_ptr for factory functions #5173

Merged
merged 2 commits into from
Sep 6, 2014
Merged

Have TkCloner return std::unique_ptr for factory functions #5173

merged 2 commits into from
Sep 6, 2014

Commits on Sep 4, 2014

  1. hide std::unique_ptr<> from ROOT 

    This file provides an easy way to hide the details of std::unique_ptr
from ROOT while still being able to use that class as a return type
for member functions parsed by ROOT.
This will be unnecessary when we switch to ROOT 6.
    @Dr15Jones
    Dr15Jones committed Sep 4, 2014
    Configuration menu
    Copy the full SHA
    11a5bce View commit details
    Browse the repository at this point in the history

  2. Have TkCloner return std::unique_ptr for factory functions 

    The static analyzer was complaining about TkCloner returning
non-const pointers from functions. These functions were purely
factory methods so the complaints were not justified. However,
the best way to silence those complaints was to change the return
type to std::unique_ptr since this enforces the ownership transfer
which was merely implicit in the previous API.
    @Dr15Jones
    Dr15Jones committed Sep 4, 2014
    Configuration menu
    Copy the full SHA
    764f5ad View commit details
    Browse the repository at this point in the history