Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing watch methods for early termination #5190

Merged

Conversation

Dr15Jones
Copy link
Contributor

When the new early termination signals were added, the additional
watch* methods were forgotten.

When the new early termination signals were added, the additional
watch* methods were forgotten.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Added missing watch methods for early termination

It involves the following packages:

FWCore/ServiceRegistry

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@Dr15Jones
Copy link
Contributor Author

@cmsbuild can the tests please be run?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

davidlange6 added a commit that referenced this pull request Sep 6, 2014
Added missing watch methods for early termination
@davidlange6 davidlange6 merged commit c0e57a8 into cms-sw:CMSSW_7_2_X Sep 6, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2014

@Dr15Jones Dr15Jones deleted the earlyTerminationSignalAddition branch September 8, 2014 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants