Port Fireworks development from 71 to 72

[alja]

• bugfix on save of configuration
• port changes in Fireworks/Tracksf
• tgeo development in Fireworks/Geometry
• cleanup of Fireworks/Geometry python scripts

[cmsbuild]

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_2_X.

Port Fireworks development from 71 to 72

It involves the following packages:

Fireworks/Core
Fireworks/FWInterface
Fireworks/Geometry
Fireworks/ParticleFlow
Fireworks/Tracks

@cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

[cmsbuild]

-1
Tested at: 0a6e42b
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-09-12-0200/src/Fireworks/Geometry/src/FWTGeoRecoGeometryESProducer.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-09-12-0200/src/Fireworks/Geometry/src/FWTGeoRecoGeometryRecord.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-09-12-0200/src/Fireworks/Geometry/src/Reg_TGeoManager.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-09-12-0200/src/Fireworks/Geometry/src/TGeoFromDddService.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-09-12-0200/src/Fireworks/Geometry/src/TGeoMgrFromDdd.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-09-12-0200/src/Fireworks/Geometry/plugins/ValidateGeometry.cc:91:8: error: 'void ValidateGeometry::validateTrackerGeometry(const DetUnitContainer&, const char_)' cannot be overloaded
   void validateTrackerGeometry(const TrackerGeometry::DetUnitContainer& dets, 
        ^
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-09-12-0200/src/Fireworks/Geometry/plugins/ValidateGeometry.cc:88:8: error: with 'void ValidateGeometry::validateTrackerGeometry(const DetContainer&, const char_)'
   void validateTrackerGeometry(const TrackerGeometry::DetContainer& dets, 
        ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5271/911/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

[cmsbuild]

+1
Tested at: 6643b82
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5271/939/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5271/939/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).