Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deriving ts5 correction from ts4 #5273

Merged
merged 2 commits into from Sep 30, 2014
Merged

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Sep 11, 2014

This modification uses "a_1" function to derive
time slice 5 charge from time slice 4

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @igv4321 for CMSSW_7_2_X.

deriving ts5 correction from ts4

It involves the following packages:

CondFormats/HcalObjects

@apfeiffer1, @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Sep 25, 2014

@apfeiffer1 ping ;-) It is your turn now!

@apfeiffer1
Copy link
Contributor

+1
sorry for overlooking this one !

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 30, 2014
deriving ts5 correction from ts4
@davidlange6 davidlange6 merged commit ca8d7eb into cms-sw:CMSSW_7_2_X Sep 30, 2014
@igv4321 igv4321 deleted the ts5-from-ts4 branch October 5, 2014 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants