Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrono: improvements to IFUNC and native timers #5309

Merged
merged 1 commit into from Sep 17, 2014
Merged

chrono: improvements to IFUNC and native timers #5309

merged 1 commit into from Sep 17, 2014

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 16, 2014

  • check for GCC >= 4.6 (not only GLIBC >= 2.11.2) before using IFUNC
  • implement native IFUNC-based timer
  • implement fall-back mechanism when IFUNC is not available
  • clean up native TSC timers

@fwyzard
chrono: improvements to IFUNC and native timers
2ae0184 
  - check for GCC >= 4.6 (not only GLIBC >= 2.11.2) before using IFUNC
  - implement native IFUNC-based timer
  - implement fall-back mechanism when IFUNC is not available
  - clean up native TSC timers
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 16, 2014

+1

please pick for CMSSW_7_2_X as soon as convenient, in order to fix compilation with CLANG

@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 16, 2014
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. @nclopezo can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
Tested at: 2ae0184
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log
----- Begin Fatal Exception 16-Sep-2014 21:27:54 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5309/962/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing). @nclopezo can you please take care of it?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5309/962/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing). @nclopezo can you please take care of it?

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 16, 2014

Hi,
the error is definitely unrelated to this PR, as it does not affect any
workflow - it only updates files under .../test, which are not used
anywhere else.

.A

On 17 September 2014 00:02, cmsbuild notifications@github.com wrote:

This pull request is fully signed and it will be integrated in one of the
next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing).
@nclopezo https://github.com/nclopezo can you please take care of it?

—
Reply to this email directly or view it on GitHub
#5309 (comment).

@cmsbuild
Copy link
Contributor

+1
Tested at: 2ae0184
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5309/977/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5309/977/summary.html

@cmsbuild cmsbuild mentioned this pull request Sep 17, 2014
Merged
davidlange6 added a commit that referenced this pull request Sep 17, 2014
@davidlange6
Merge pull request #5309 from fwyzard/chrono_fix_IFUNC_for_clang
b63676e 
chrono: improvements to IFUNC and native timers
@davidlange6 davidlange6 merged commit b63676e into cms-sw:CMSSW_7_2_X Sep 17, 2014
@fwyzard fwyzard deleted the chrono_fix_IFUNC_for_clang branch December 23, 2014 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fwyzard @cmsbuild @davidlange6