New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide only const access to ME0EtaPartitions #5318
Provide only const access to ME0EtaPartitions #5318
Conversation
The const function ME0Geometry::etaPartitions() was allowing non-const access to the ME0EtaPartitions. This modification fixes that in order to avoid thread safety issues.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X. Provide only const access to ME0EtaPartitions It involves the following packages: Geometry/GEMGeometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. @nclopezo can you please take care of it? |
@dildick - Please, check that similar changes are propagated to GEM geometry and digitises. Thanks. |
I should have spotted that one, since I did fix it in the GEM geometry. How do I check the GEM/ME0 simulation for thread safety issues? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
Provide only const access to ME0EtaPartitions
The const function ME0Geometry::etaPartitions() was allowing non-const
access to the ME0EtaPartitions. This modification fixes that in order
to avoid thread safety issues.