Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLHC: revert FWRecoGeomteryESProducer ME0 change in the previous commit, add ME0 in TGeo reco #5323

Merged
merged 3 commits into from Sep 19, 2014

Conversation

alja
Copy link
Contributor

@alja alja commented Sep 16, 2014

I have accidentally lost ME0 change in merge from 71 and SLHC. This is fixed in the first commit.

The PR also contains add import of ME0 in reco TGeo geometry.

@alja
Copy link
Contributor Author

alja commented Sep 16, 2014

Muon TGeo reco geomtery

Produce

scram b -j 12 && cmsRun python/dumpRecoGeometry_cfg.py tag=2023Muon tgeo=true

Run Display

cmsShow -c muon.fwc --sim-geom-file cmsTGeoRecoGeom-2023Muon.root

config file at https://amraktad.web.cern.ch/amraktad/muon.fwc
simplemuon

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_6_2_X_SLHC.

SLHC: revert ME0 related changes from the previous commit, add ME0 in TGeo reco

It involves the following packages:

Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja alja closed this Sep 16, 2014
@alja alja reopened this Sep 16, 2014
@alja
Copy link
Contributor Author

alja commented Sep 16, 2014

Muon Detectors in TGeo reco geometry

mm

@alja
Copy link
Contributor Author

alja commented Sep 16, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

@alja
Copy link
Contributor Author

alja commented Sep 16, 2014

@mmaggi , @ianna
I'm sorry I override your ME0 changes in FWRecoGeometryESProducer in the previous commit. They are reverted back.

@alja alja changed the title SLHC: revert ME0 related changes from the previous commit, add ME0 in TGeo reco SLHC: revert FWRecoGeomteryESProducer ME0 change in the previous commit, add ME0 in TGeo reco Sep 16, 2014
@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Sep 19, 2014
SLHC: revert FWRecoGeomteryESProducer ME0 change in  the previous commit, add ME0 in TGeo reco
@cmsbuild cmsbuild merged commit 2cbcde7 into cms-sw:CMSSW_6_2_X_SLHC Sep 19, 2014
@alja alja deleted the me0-slhc branch May 11, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants