Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of pileup mitigation JetMET developments and JetMet bug fixes in central release #5388

Merged
merged 29 commits into from Oct 9, 2014

Conversation

cmsbuild
Copy link
Contributor

This PR contains the MVA and NoPU code the JetMET group wants to make available centrally, and eventually computed at the RECO and miniAOD level after discussion with the RECO/AT group.

This PR add the package RecoMET/METPUSubtraction, and add the pat configuration files needed for the MET uncertainty tool.
Several fixes and cleaning are also done on the patCaloMET configuration, the pileupjetid configuration, the pileupJetid training needed by the MVA and NoPU MET.

Automatically ported from CMSSW_7_2_X #5188

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_3_X.

Integration of MVA/NoPU MET in central release

It involves the following packages:

PhysicsTools/PatUtils
RecoJets/JetProducers
RecoMET/METPUSubtraction

The following packages do not have a category, yet:

RecoMET/METPUSubtraction

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @ktf can you please review it and eventually sign? Thanks.
@nhanvtran, @yslai, @TaiSakuma, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@nclopezo
Copy link
Contributor

+1
The version of this PR in 7_2_X passed the jenkins tests.

@StoyanStoynev
Copy link
Contributor

@monttj @vadler
Volker and Tae Jeong we will need your signature here too, if you don't have any further comments.

@davidlange6
Copy link
Contributor

@vadler - @monttj - should we go ahead?

@slava77
Copy link
Contributor

slava77 commented Oct 9, 2014

@mmarionncern
Matthieu
please update the subject of the PR to mention of other changes here, as discussed in the RECO meeting.
Thanks.

@mmarionncern
Copy link

@slava77 I just noticed that I can't update the title, this request has been ported automatically from the original one planned for 72X

@slava77
Copy link
Contributor

slava77 commented Oct 9, 2014

@mmarionncern please post your preferred subject name here and Giulio ( @ktf ) or someone can update it.

@mmarionncern
Copy link

@slava77
"Integration of pileup mitigation JetMET developments and JetMet bug fixes in central release"
should do the job

@monttj
Copy link
Contributor

monttj commented Oct 9, 2014

+1
Volker already signed it. And the last update is about fixing the error.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Oct 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 9, 2014
Integration of MVA/NoPU MET in central release.
@ktf ktf merged commit 3983abd into cms-sw:CMSSW_7_3_X Oct 9, 2014
@slava77
Copy link
Contributor

slava77 commented Oct 9, 2014

@ktf
Giulio, please update the subject of the PR to "Integration of pileup mitigation JetMET developments and JetMet bug fixes in central release"

@ktf ktf changed the title Integration of MVA/NoPU MET in central release Integration of pileup mitigation JetMET developments and JetMet bug fixes in central release Oct 11, 2014
@mmarionncern mmarionncern deleted the 72X-MVANoPUMet-20140718 branch November 14, 2016 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants