Changes needed because of changes in the API for clang v3.5

[gartung]

This pull needs to wait for clang 3.5

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_2_X.

Changes needed because of changes in the API for clang v3.5

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
Tested at: fd054b7
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481-testing/CMSSW_7_2_X_2014-09-18-0200/src/Utilities/StaticAnalyzers/src/ClangCmsCheckerPluginRegister.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481-testing/CMSSW_7_2_X_2014-09-18-0200/src/Utilities/StaticAnalyzers/src/ClassChecker.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481-testing/CMSSW_7_2_X_2014-09-18-0200/src/Utilities/StaticAnalyzers/src/ClassDumper.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481-testing/CMSSW_7_2_X_2014-09-18-0200/src/Utilities/StaticAnalyzers/src/CmsException.cpp 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481-testing/CMSSW_7_2_X_2014-09-18-0200/src/Utilities/StaticAnalyzers/src/CatchAll.cpp: In member function 'void clangcms::CatchAll::checkASTCodeBody(const clang::Decl_&, clang::ento::AnalysisManager&, clang::ento::BugReporter&) const':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481-testing/CMSSW_7_2_X_2014-09-18-0200/src/Utilities/StaticAnalyzers/src/CatchAll.cpp:22:134: error: no matching function for call to 'clang::ento::BugReporter::EmitBasicReport(const clang::Decl_&, const clangcms::CatchAll\* const, const char [24], const char [15], const char [32], clang::ento::PathDiagnosticLocation&, clang::SourceRange)'
   BR.EmitBasicReport(D, this, "'catch(...)' in sources","CMS code rules","using 'catch(...)' is forbidden", DLoc,s->getSourceRange ());
                                                                                                                                      ^
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481-testing/CMSSW_7_2_X_2014-09-18-0200/src/Utilities/StaticAnalyzers/src/CatchAll.cpp:22:134: note: candidate is:
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/external/llvm/3.4-cms2/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:22:0,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/external/llvm/3.4-cms2/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:18,


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5403/25/summary.html

[Dr15Jones]

This needs to be built against a release which has the new clang.

[ghost]

It should be possible to test in against CMSSW_7_2_DEVEL_X_2014-09-18-1400 or later once it will be done.

[gartung]

Change to CMSSW_7_2_DEVEL_X branch

[cmsbuild]

Pull request #5403 was updated. @diguida, @ianna, @cerminar, @Martin-Grunewald, @rcastello, @bendavid, @perrotta, @civanch, @cmsbuild, @fwyzard, @ktf, @vciulli, @Dr15Jones, @mdhildreth, @slava77, @mommsen, @vadler, @mulhearn, @nclopezo, @emeschi, @thuer, @monttj, @StoyanStoynev can you please check and sign again.

[cmsbuild]

Pull request #5403 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

[Dr15Jones]

The pull request needs to be for the. 7_2_DEVEL_X branch since that is the one with the new clang at the moment.

[gartung]

@Dr15Jones I submitted pull request #5414 against 7_2_DEVEL_X but you approval has a typo in it.

[ghost]

+1
Tested against llvm 3.5 with workflows: 401.0,1306.0,101.0,1003.0,50101.0,9.0.