Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uninitialised var timetype to avoid error from checker #5405

Merged
merged 2 commits into from Sep 23, 2014

Conversation

apfeiffer1
Copy link
Contributor

@apfeiffer1
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

fix uninitialised var timetype to avoid error from checker

It involves the following packages:

CondCore/ESSources

@cmsbuild, @diguida, @rcastello, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor Author

+1
as the robot did not see my earlier +1 .. :(

On Thu, Sep 18, 2014 at 12:12 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @apfeiffer1
https://github.com/apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

fix uninitialised var timetype to avoid error from checker

It involves the following packages:

CondCore/ESSources

@cmsbuild https://github.com/cmsbuild, @diguida
https://github.com/diguida, @rcastello https://github.com/rcastello,
@cerminar https://github.com/cerminar, @nclopezo
https://github.com/nclopezo can you please review it and eventually
sign? Thanks.
@ghellwig https://github.com/ghellwig this is something you requested
to watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@nclopezo https://github.com/nclopezo you are the release manager for
this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#5405 (comment).

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Sep 18, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@@ -344,7 +344,7 @@ CondDBESSource::setIntervalFor( const edm::eventsetup::EventSetupRecordKey& iKey

// compute the smallest interval (assume all objects have the same timetype....)
cond::ValidityInterval recordValidity(1,cond::TIMELIMIT);
cond::TimeType timetype;
cond::TimeType timetype = cond::TimeType::invalid;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is extra ; at the end.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlt
Thanks for noticing this: it seems that I need a review of my glasses! ;-)
Question: why do the tests run fine?

davidlange6 added a commit that referenced this pull request Sep 23, 2014
fix uninitialised var timetype to avoid error from checker
@davidlange6 davidlange6 merged commit 29c632c into cms-sw:CMSSW_7_2_X Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants