New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix uninitialised var timetype to avoid error from checker #5405
fix uninitialised var timetype to avoid error from checker #5405
Conversation
+1 |
A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X. fix uninitialised var timetype to avoid error from checker It involves the following packages: CondCore/ESSources @cmsbuild, @diguida, @rcastello, @cerminar, @nclopezo can you please review it and eventually sign? Thanks. |
+1 On Thu, Sep 18, 2014 at 12:12 PM, cmsbuild notifications@github.com wrote:
Thanks, |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
@@ -344,7 +344,7 @@ CondDBESSource::setIntervalFor( const edm::eventsetup::EventSetupRecordKey& iKey | |||
|
|||
// compute the smallest interval (assume all objects have the same timetype....) | |||
cond::ValidityInterval recordValidity(1,cond::TIMELIMIT); | |||
cond::TimeType timetype; | |||
cond::TimeType timetype = cond::TimeType::invalid;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is extra ;
at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidlt
Thanks for noticing this: it seems that I need a review of my glasses! ;-)
Question: why do the tests run fine?
fix uninitialised var timetype to avoid error from checker
... as reported by DavidA in https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3051.html