RPC DQM migration to DQMEDHarvester

[acimmino]

RPC clients have been migrated to the DQMEDHarvester interface as described in:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/ThreadedDQM

Also removed obsolete modules that were not used anymore

[cmsbuild]

A new Pull Request was created by @acimmino (Anna Cimmino) for CMSSW_7_3_X.

RPC DQM migration to DQMEDHarvester

It involves the following packages:

DQM/RPCMonitorClient

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: f241928
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5410/9/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5410/9/summary.html

[deguio]

ciao anna,
many thanks for this. just a couple of minor comments:

• it seems to me that the class RPCQualityTests is not needed. am I wrong? is it possible to remove it?
• in RPCRecHitProbabilityClient could you remove the instances of dbe_?

apart from this I think that the PR is ready to be merged.
thanks,
F.

[acimmino]

Ciao Federico,

I'm making the changes you proposed. Can I profit of this occasion and make a very small bug fix to DQM/RPCMonitorDigi/src/RPCMonitorDigi.C. The bug fix I'd like to make is

OLD Lines:
474: int xbin = wheelOrDiskNumber+3;
475: if (region==-1) xbin = wheelOrDiskNumber+4;
476: if(meRegion[os.str()]) meRegion[os.str()]->Fill(xbin,ring,numDigi);

NEW Lines:
474: int xbin = wheelOrDiskNumber+ numberOfDisks_ ;
475: if (region==-1) {xbin = wheelOrDiskNumber+ numberOfDisks_ +1;}
476: if(meRegion[os.str()]) {meRegion[os.str()]->Fill(xbin,ring,numDigi);}

If you prefer, I can put it in a subsequent PR instead.
Cheers,
Anna

---

From: deguio [notifications@github.com]
Sent: 29 September 2014 17:32
To: cms-sw/cmssw
Cc: Anna Cimmino
Subject: Re: [cmssw] RPC DQM migration to DQMEDHarvester (#5410)

ciao anna,
many thanks for this. just a couple of minor comments:

• it seems to me that the class RPCQualityTests is not needed. am I wrong? is it possible to remove it?
• in RPCRecHitProbabilityClient could you remove the instances of dbe_?

apart from this I think that the PR is ready to be merged.
thanks,
F.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5410#issuecomment-57179027.

[deguio]

it is fine. we can merge all together.
thanks,
F.

[deguio]

not sure if I have to wait for additional commits here. let me know if this is not the case.
thanks,
F.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
Tested at: a55a6e0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5410/202/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5410/202/summary.html

[ktf]

I think this broke the IBs.

----- Begin Fatal Exception 09-Oct-2014 00:08:39 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'RPCFEDIntegrity' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

can you please check?

[deguio]

ciao @ktf @acimmino
I have realized the same few minutes ago. the reason is the removal of the lines at:
https://github.com/cms-sw/cmssw/pull/5410/files#diff-f81dbe13b162bb67239a55a1d20aff61L10

anna, could you provide a fix for this? was the removal of DQM/RPCMonitorClient/src/SealModule.cc accidental?

to reproduce the problem you can runTheMatrix.py -l 4.78

thanks,
F.

[ktf]

Any news on this? I'll revert everything otherwise.

[davidlange6]

seems we should revert if no fix by 1400 IB then we have a good basis for the weekend..

On Oct 10, 2014, at 10:55 AM, Giulio Eulisse notifications@github.com wrote:

Any news on this? I'll revert everything otherwise.

—
Reply to this email directly or view it on GitHub.

[acimmino]

Sorry,

I was internetless from Friday onwards. I'll provide a fix by Monday. Thanks for reverting in the meantime.

Cheers,
Anna

---

From: David Lange [notifications@github.com]
Sent: 10 October 2014 12:13
To: cms-sw/cmssw
Cc: Anna Cimmino
Subject: Re: [cmssw] RPC DQM migration to DQMEDHarvester (#5410)

seems we should revert if no fix by 1400 IB then we have a good basis for the weekend..

On Oct 10, 2014, at 10:55 AM, Giulio Eulisse notifications@github.com wrote:

Any news on this? I'll revert everything otherwise.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5410#issuecomment-58637001.