Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Runtime Crashing Issues #5412

Merged
merged 2 commits into from Sep 23, 2014

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 18, 2014

  • The code has been ported to the new Geant4
  • Remaining issues:
    • Material maps are not built, see line 205 in MaterialBudgetData.cc
    • Event number is not printed

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_7_2_X.

Fix Runtime Crashing Issues

It involves the following packages:

Validation/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented Sep 18, 2014

@civanch - The instructions to run material budget validation are here: https://twiki.cern.ch/twiki/bin/view/CMSPublic/TrackerMaterialBudgetplots

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor Author

ianna commented Sep 19, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 23, 2014
@davidlange6 davidlange6 merged commit 47b9722 into cms-sw:CMSSW_7_2_X Sep 23, 2014
@ianna ianna deleted the material-budget-validation branch October 26, 2015 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants